Skip to content
This repository has been archived by the owner on Mar 22, 2019. It is now read-only.

Find C#/VB targets using MSBuildToolsVersion #1

Closed
wants to merge 1 commit into from

Conversation

rainersigwald
Copy link

Adds support for Visual Studio 2019 by using MSBuildToolsVersion instead of VisualStudioVersion, since they no longer match after dotnet/msbuild#3778.

This is a port of novotnyllc/MSBuildSdkExtras#128.

This change does not break Visual Studio 2017 compatibility: there, the two variables have the same value 15.0. In 2019, they differ.

Adds support for Visual Studio 2019 by using MSBuildToolsVersion instead
of VisualStudioVersion, since they no longer match after
dotnet/msbuild#3778.
@rainersigwald
Copy link
Author

By the way, @wjk, would you mind disconnecting this repo from Microsoft/MSBuildSdks? That way people can file bugs on it directly.

@wjk
Copy link
Member

wjk commented Mar 22, 2019

@rainersigwald Thank you for your contribution, but since .NET Core 3.0 was released, the WindowsForms and WPF SDKs in this repository are now obsolete; I have moved over to using Microsoft.NET.Sdk.WindowsDesktop for all my projects. Since this repo only existed so I could have a place to host those two SDKs, I'm going to archive it now. Sorry for wasting your time! 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants