stringify and ensure meta is not set for logs

SungardAS · Dec 16, 2016 · d305a9d · d305a9d
1 parent 8475711
commit d305a9d
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 10 deletions.
diff --git a/lib/log.js b/lib/log.js
@@ -7,10 +7,9 @@ module.exports.getLogger = function() {
     transports: [
       new (winston.transports.Console)({
         level: properties.logLevel,
-        json: false,
+        json: true,
         stringify: true,
-        timestamp: true,
-        prettyPrint: true
+        timestamp: true
       })
     ]
   });

diff --git a/lib/resources/elasticgroup/create.js b/lib/resources/elasticgroup/create.js
@@ -12,8 +12,7 @@ var create = function(err, event, context) {
   spotUtil.getTokenAndConfig(event, function(err, tc) {
     if(err) return spotUtil.done(err, event, context);
 
-    log.debug("Spotinst Create Event");
-    log.debug(event);
+    log.debug("Spotinst Create Event", event, {});
 
     var createOptions = {
       method:  'POST',
@@ -27,10 +26,10 @@ var create = function(err, event, context) {
       }
     };
 
-    log.info('Creating group config', tc.config);
+    log.info('Creating group config', tc.config, {});
     request(createOptions, function(err, res, body) {
 
-      log.debug("Create group payload",body);
+      log.debug("Create group payload",body, {});
 
       spotUtil.validateResponse({
         err:       err,
@@ -41,7 +40,7 @@ var create = function(err, event, context) {
         resource:  'elasticgroup',
         action:    'create',
         successCb: function(spotResponse) {
-          log.debug("Create Success Callback",spotResponse);
+          log.debug("Create Success Callback");
           spotUtil.done(err, event, context, body, body.response.items[0].id);
         }
       });

diff --git a/lib/util.js b/lib/util.js
@@ -118,7 +118,7 @@ var validateResponse = module.exports.validateResponse = function(spotResponse)
   var context = spotResponse.context;
 
   //log.info('Spotinst response',JSON.stringify(body, null, 2));
-  log.info('Spotinst response',body);
+  log.info('Spotinst response',body, {});
 
   if(res.statusCode > 201) {
     var errMsg = '';

diff --git a/test/elasticgroup/create.js b/test/elasticgroup/create.js
@@ -48,7 +48,7 @@ var groupConfig = {
 }
 
 describe("elasticgroup", function() {
-  describe("create resource", function() {
+  describe.only("create resource", function() {
     before(function() {
       for (var i=0; i<4; i++) {
         nock('https://api.spotinst.io', {"encodedQueryParams":true})