[WIP] Core/Movement: Improve player movement (part 2) #67

kelno · 2018-10-18T15:20:56Z

Continuation of PR #55
Discussion is still ongoing at TrinityCore/TrinityCore#18771

The problem is with active mover switching, part of this previous PR has been disabled.
Check TODOMOV in the master code to see the part to re enable when this is fixed.

When switching active mover, the client does start movement immediately then only receive the spline, resulting in a backward movement. The client always send two movement packet immediately when taking control, but those are are always discarded (and they may violate current unit move flags). How to fix this?
Pending changes timeout probably needs a fix. GetMSTime does restart to 0 over time.
LogoutPlayer instead of Kick?

… TrinityCore/#22416)

…for that)

…ly if creature has moved

…acky system anymore

…how hex in .getmoveflags)

…ectly

…2 different auras + Related test

…rding and molten shield, respectively)

…nce" between them and the target creature

- Unified movement packet time handling - Improved movement packet time handling - Removed some unused functions - Save last client/server timestamps when receiving move packets

…woiwoz)

…ter the server was restarted and the instance loaded from DB data

…if creature_entry contains a spawnId not in creature table

… other)

… gameobjects

…essed by the packet handler

* WIP * Fixed broken CMSG_MOVE_SPLINE_DONE structure for TBC * Improved SetMovedUnit logic + re enabled IsInClientControlSet checks + Protect CMSG_SET_ACTIVE_MOVER against not allowed guid given from client * Restore walk after a CM from a Player * Experimental implementation of CMSG_MOVE_TIME_SKIPPED * Completely reworked Active Mover system. Reworked Movement Pending Changes. Reworked movement packet delay. Added some movement logging. Actually rewritten the whole server. * (chaosdhib) fix the order of application of spell effects on spells with client control removal and speed movement change based on observation of retail * Various fixes + Implemented first version of moveflags transfer when changing unit (not finished) * Restored multiple units allowed control * Fixed possible crash when changing mover * Fixed active mover transfer spline movement incorrectly using mmaps * More tweaks to active mover switching * Fixes to active mover switching * Fixed another bug with active mover change * Implement timeout on active mover release, measure against cheating * Fixed release timeout * Disable part of the feature of this PR to make it usable and testable as is. Flag movement transfer on active change is disabled for now.

kelno and others added 30 commits September 9, 2018 22:01

Moved alterac valley scripts

8fa83b1

Pack58: Added two known taxis

ca80ff1

Moved old updates

d0eee19

Core/VMaps: Fix no collision triangles

5447aea

Missed in last commit

f49f8fb

Fixed vmaps extraction

d28e761

Update .travis.yml

55186ab

[TC] Core/EscortAI: initialize run state before filling waypoints (PR…

6b4ba29

… TrinityCore/#22416)

Update systemctl service

83556d2

Notify GMs of BossState changes

3a996bd

Notify failures for .tele command

5cd22cf

AI: A non accessible target is a valid target if we're stationary

d89f56b

Revert dc89c3f

b0e8f18

Removed old creature rotation system (we now use a MovementGenerator …

2e86988

…for that)

Re enabled UpdateMovementFlags for creature, but with a period and on…

5677d13

…ly if creature has moved

Removed transportCheckTimer system from Sunwell, we don't need this h…

bf3690e

…acky system anymore

Renamed SetCanFly -> _SetCanFly to avoid confusion with TC function

6fd0894

Commands: Allow to use hexadecimal with commands .setmoveflags (and s…

fab8736

…how hex in .getmoveflags)

Moved two Player functions to their correct file

b7f7a92

Spells: Reimplement SPELL_ATTR0_CU_SAME_STACK_DIFF_CASTERS

3330c7e

Spells: Fixed positivity for spell 38044

ebcccf8

Fixed #34

16a0de6

Spells: Allow several spell immunities of the same kind to stack corr…

5ab929c

…ectly

Some renames

2479854

Fixed build

ff6c08c

Spells: Fixed spell immunity stacking when the same spell is used by …

a15e3f1

…2 different auras + Related test

Fixed some database loading types

bf24d0a

Spells: Fixed paladin seal of light judgement

4a6efef

Spells: Fixed target for some triggered aoe spells

784900b

Scripting: Allow to SummonList::IsAlive to be filter by creature entry

5d07d60

kelno and others added 25 commits October 15, 2018 12:05

Missing this part in 5fe9d5f

e5f261e

Fixed mage frost and fire ward reflect chances (with talents frost wa…

d81c3a7

…rding and molten shield, respectively)

DB: Removed some wrong creature mounts

1acf438

Fixed melee pets chasing targets too close, possibly leading to a "da…

16b655e

…nce" between them and the target creature

Some random cleanups from PR #55

a2249c7

Various fixes from PR #55:

876cab1

- Unified movement packet time handling - Improved movement packet time handling - Removed some unused functions - Save last client/server timestamps when receiving move packets

Fixed build

ecaa1d4

Fixed missing spawns in SSC + Visual effects near Hydross Towers (by …

fbbf7bf

…woiwoz)

Fixed raids with old instance scripts not having creatures spawned af…

9b203b3

…ter the server was restarted and the instance loaded from DB data

Updated almost all creature speeds

4800cdd

Fixed .npc formation add angle

c5c0200

Fixed .npc add command

7dc0091

Fixed a possible crash if creature table contains an invalid map, or …

3e25206

…if creature_entry contains a spawnId not in creature table

Fixed last two commits

5f0f0d9

DB: Change waypoints_scripts and waypoint_data FKs

0be1bcb

DB: Add foreign keys to creature_addon and creature_template_addon

05d08d8

Clean MoveChase parameters. (Also fixes creatures dancing around each…

3c18ae4

… other)

Fixed skinnable creatures disappearing immediately

82fae31

Fixed InstanceScript::OnGameObjectCreate getting called two times per…

d819391

… gameobjects

Fixed movement packets wrong time sent. Smooth movement is here!

ee1537a

Anticheat: Send new movement to anticheat before new position is proc…

b17448b

…essed by the packet handler

Update .travis.yml

ad03e9a

Fix Travis sql config

a2c6c19

Dummy

d640c1c

kelno force-pushed the master branch 2 times, most recently from 40b804d to 78ee128 Compare December 21, 2018 18:20

kelno closed this Feb 3, 2019

kelno force-pushed the master branch from a9a5f35 to a739792 Compare February 3, 2019 21:41

kelno deleted the playermovementrework2 branch September 15, 2019 16:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] Core/Movement: Improve player movement (part 2) #67

[WIP] Core/Movement: Improve player movement (part 2) #67

kelno commented Oct 18, 2018 •

edited

[WIP] Core/Movement: Improve player movement (part 2) #67

[WIP] Core/Movement: Improve player movement (part 2) #67

Conversation

kelno commented Oct 18, 2018 • edited

kelno commented Oct 18, 2018 •

edited