-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release: RST 4.6 #441
Release: RST 4.6 #441
Conversation
Co-authored-by: Emma Bland <emma.bland@unis.no>
Co-authored-by: Emma Bland <emma.bland@unis.no>
Co-authored-by: Marina Schmidt <marina.t.schmidt@gmail.com>
Co-authored-by: Emma Bland <emma.bland@unis.no>
Adding missing chisham keyword to RadarFldPnth in native IDL RadarPos function
Developer Workflow Documentation: Code Review
Doc/rfc content move
Co-authored-by: Emma Bland <emma.bland@unis.no>
Co-authored-by: Emma Bland <emma.bland@unis.no>
Co-authored-by: Emma Bland <emma.bland@unis.no>
Add missing "-ftrmcol" command line option to fov_plot
Co-authored-by: Emma Bland <emma.bland@unis.no>
Co-authored-by: Emma Bland <emma.bland@unis.no>
Co-authored-by: Emma Bland <emma.bland@unis.no>
Co-authored-by: Emma Bland <emma.bland@unis.no>
GPLv3 license and copyright information for developers
List of former (and current) RST developers
Fix bug in trim_raw
Here's a brief description of this release that can be used on Zenodo and elsewhere. Please me know if anything is missing 😄 Key updates in version 4.6 of the Radar Software Toolkit (RST) include:
The RST is actively developed and maintained by the SuperDARN Data Analysis Working Group (https://superdarn.github.io/dawg/). |
Looks good got it installed on OpenSuse Leap 15.2 and tested make_fit and datdump |
I think this is basically ready to go, but I just got a request from the DCN PI to update the hardware file with a new TDIFF value. New version is on its way Edit: the updated hdw file will be provided by Friday this week |
At thought at some point I or someone had added Ubuntu 20 dependencies to the install instructions, but I don't see them there. I've just run through an Ubuntu 20 install and could add them here. Thoughts? Maybe I'm remembering adding the Ubuntu 18 dependencies... |
Are they any different to Ubuntu 18? |
Very very slightly. Ubuntu 20 doesn't ship with make or gcc it seems (or at least my install didn't), so you have to add those in. The install line is slightly different too: |
Ok, go for it then! We're still waiting on the DCN hardware file anyway. Is it just |
OK, I've got the Ubuntu 20 install notes with 398e22c. Hopefully the formatting looks OK on the read-the-docs site, don't think we've got a release branch version of read-the-docs going, do we? |
I tried to get this working a few weeks ago, but readthedocs couldn't see the release branch. I just checked again, and magically it's working...here's the link: https://radar-software-toolkit-rst.readthedocs.io/en/release-rst-4.6/ I think the table of contents on the homepage needs some work...I'll take a look at that tomorrow. |
Ok, thanks for pointing me to that...I didn't try very hard to figure out how to convert the Agreed, the table of contents on the home page fairly expanded when I pull over content from the RFCs. I at least tried to keep it organized. Maybe some of the sections can be condensed with expand/collapse measure features much like the left-hand navigation bar. If it's too much, I wouldn't worry about it, we can refine that for a future release. |
Cleanup readthedocs to fix links and move developer content towards the bottom of the menu
@ksterne Can we make the release now? |
Yes, though I'm not in a great position to hit the button to merge until Thursday (too many meetings). Feel free to move it along without me. I've just reviewed the checklist and added a draft release to the repo with the summary of changes that was provided. So I think we're through step 9 (we've probably indirectly reminded people on testing). For step 11, we'll want to edit the draft release to point to |
Release RST 4.6
Deadline: 19 July 2021
Please comment in the Pull Request conversation if you need additional time to test the release.
Testing
Do any binaries/libraries require special attention during testing?
Below are the major updates. Of course these have already been tested, but feel free to try to "break" them 😄
make_fit -fitacf-version 3.0
- fixed "divide by zero" bug that affects noise level determination for BOREALIS radars (Revising the noise calculation in FITACF3.0 #420 . Added Shepherd (2017) elevation angle algorithmmake_grid
- see Fix/make grid #373fit_speck_removal
- new binary, see Routine to remove noise/interference from FITACF files #400datdump
- new binary, see adding datdump binary #376fov_plot
- new functionality, see Multi-radar FOV plots with fov_plot #440How to test
Install git, and then run:
Alternatively, download a zip archive of the release branch and then run
make.build && make.code
as usual. You may need to update some environment variables for this to work.From there, please use RST as normal and play with the new features listed above.
Checklist
radar.dat
-- not required this time.rst.version
.zenodo.json
. @ksterne and I will provide a draft author list ASAPExtra Notes
All hardware files have been updated to match the new file format on the
hdw
repo.The DCE and DCN radars have updated information (see SuperDARN/hdw#1).
Approving the release
After testing, please state which operating system you used and what you tested.
If you found no bugs during testing, please approve the PR:
files changed
top rightstart review
green top right buttonapprove
andsubmit review