Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release: RST 4.6 #441

Merged
merged 432 commits into from
Aug 3, 2021
Merged

Release: RST 4.6 #441

merged 432 commits into from
Aug 3, 2021

Conversation

ecbland
Copy link

@ecbland ecbland commented Jun 21, 2021

Release RST 4.6

  • PATCH
  • MINOR
  • MAJOR

Deadline: 19 July 2021

Please comment in the Pull Request conversation if you need additional time to test the release.

Testing

  • Mac OSx
  • Linux deb - Debian, Ubuntu, Mint
  • Linux rpm - OpenSuse, Fedora, CentOS

Do any binaries/libraries require special attention during testing?

Below are the major updates. Of course these have already been tested, but feel free to try to "break" them 😄

How to test

Install git, and then run:

git clone https://github.com/SuperDARN/rst
cd rst
git checkout release/rst-4.6
make.build && make.code

Alternatively, download a zip archive of the release branch and then run make.build && make.code as usual. You may need to update some environment variables for this to work.

From there, please use RST as normal and play with the new features listed above.

Checklist

  • Update radar.dat -- not required this time
  • Update hardware files (if required)
  • Update .rst.version
  • Update author list in .zenodo.json. @ksterne and I will provide a draft author list ASAP
  • Write a list of major updates for the release description

Extra Notes

All hardware files have been updated to match the new file format on the hdw repo.
The DCE and DCN radars have updated information (see SuperDARN/hdw#1).

Approving the release

After testing, please state which operating system you used and what you tested.

If you found no bugs during testing, please approve the PR:

  1. Click on files changed top right
  2. Click on start review green top right button
  3. In the comment box, state which operating system you used for testing, and any other helpful information
  4. Select approve and submit review

mts299 and others added 30 commits February 18, 2021 12:23
Co-authored-by: Emma Bland <emma.bland@unis.no>
Co-authored-by: Emma Bland <emma.bland@unis.no>
Co-authored-by: Marina Schmidt <marina.t.schmidt@gmail.com>
Co-authored-by: Emma Bland <emma.bland@unis.no>
Adding missing chisham keyword to RadarFldPnth in native IDL RadarPos function
Developer Workflow Documentation: Code Review
Co-authored-by: Emma Bland <emma.bland@unis.no>
Co-authored-by: Emma Bland <emma.bland@unis.no>
Co-authored-by: Emma Bland <emma.bland@unis.no>
Add missing "-ftrmcol" command line option to fov_plot
Co-authored-by: Emma Bland <emma.bland@unis.no>
Co-authored-by: Emma Bland <emma.bland@unis.no>
Co-authored-by: Emma Bland <emma.bland@unis.no>
Co-authored-by: Emma Bland <emma.bland@unis.no>
GPLv3 license and copyright information for developers
List of former (and current) RST developers
@ecbland
Copy link
Author

ecbland commented Jul 21, 2021

Here's a brief description of this release that can be used on Zenodo and elsewhere. Please me know if anything is missing 😄


Key updates in version 4.6 of the Radar Software Toolkit (RST) include:

  • Routine for removing non-gaussian noise/interference from fitacf files (fit_speck_removal)
  • Routine to display the contents of old-format dat files (datdump)
  • Shepherd (2017) elevation angle algorithm added to FITACF3.0
  • Ability to plot multiple fields of view with fov_plot
  • Added missing mlt2mlon keyword to MLT_v2 IDL/DLM code
  • make_grid detects and concatenates multiple input files automatically (deprecates -c flag)
  • Check that the search noise is nonzero before using it to replace the skynoise in FITACF3.0
  • Check whether interferometer array is in front or behind main array when calculating elv_low/elv_high in FITACF2.5
  • Fixed bugs in plotting libraries, cdf file reading, make_grid and trim_raw
  • Update hardware files for DCE and DCN, and PI institution information in radar.dat
  • Improved compliance with GPLv3 license requirements
  • Documentation updates

The RST is actively developed and maintained by the SuperDARN Data Analysis Working Group (https://superdarn.github.io/dawg/).

@mts299
Copy link
Contributor

mts299 commented Jul 21, 2021

Looks good got it installed on OpenSuse Leap 15.2 and tested make_fit and datdump

@ecbland
Copy link
Author

ecbland commented Jul 26, 2021

I think this is basically ready to go, but I just got a request from the DCN PI to update the hardware file with a new TDIFF value. New version is on its way

Edit: the updated hdw file will be provided by Friday this week

@ksterne
Copy link
Contributor

ksterne commented Jul 28, 2021

At thought at some point I or someone had added Ubuntu 20 dependencies to the install instructions, but I don't see them there. I've just run through an Ubuntu 20 install and could add them here. Thoughts? Maybe I'm remembering adding the Ubuntu 18 dependencies...

@ecbland
Copy link
Author

ecbland commented Jul 28, 2021

@ksterne At thought at some point I or someone had added Ubuntu 20 dependencies to the install instructions, but I don't see them there. I've just run through an Ubuntu 20 install and could add them here. Thoughts? Maybe I'm remembering adding the Ubuntu 18 dependencies...

Are they any different to Ubuntu 18?

@ksterne
Copy link
Contributor

ksterne commented Jul 28, 2021

Very very slightly. Ubuntu 20 doesn't ship with make or gcc it seems (or at least my install didn't), so you have to add those in. The install line is slightly different too: apt install replaces apt-get install.

@ecbland
Copy link
Author

ecbland commented Jul 28, 2021

Very very slightly. Ubuntu 20 doesn't ship with make or gcc it seems (or at least my install didn't), so you have to add those in. The install line is slightly different too: apt install replaces apt-get install.

Ok, go for it then! We're still waiting on the DCN hardware file anyway. Is it just build-essential that's needed? That should include both gcc and make

@ksterne
Copy link
Contributor

ksterne commented Jul 28, 2021

OK, I've got the Ubuntu 20 install notes with 398e22c. Hopefully the formatting looks OK on the read-the-docs site, don't think we've got a release branch version of read-the-docs going, do we?

@ecbland
Copy link
Author

ecbland commented Jul 28, 2021

Hopefully the formatting looks OK on the read-the-docs site, don't think we've got a release branch version of read-the-docs going, do we?

I tried to get this working a few weeks ago, but readthedocs couldn't see the release branch. I just checked again, and magically it's working...here's the link: https://radar-software-toolkit-rst.readthedocs.io/en/release-rst-4.6/

I think the table of contents on the homepage needs some work...I'll take a look at that tomorrow.

@ksterne
Copy link
Contributor

ksterne commented Jul 28, 2021

Ok, thanks for pointing me to that...I didn't try very hard to figure out how to convert the / to a URL character. Looks like the table needed some help to create some empty cells, so I've fixed that with 7957a91. Otherwise, the build-essential was under 18.04.

Agreed, the table of contents on the home page fairly expanded when I pull over content from the RFCs. I at least tried to keep it organized. Maybe some of the sections can be condensed with expand/collapse measure features much like the left-hand navigation bar. If it's too much, I wouldn't worry about it, we can refine that for a future release.

@ecbland ecbland mentioned this pull request Jul 29, 2021
Emma Bland and others added 2 commits July 30, 2021 16:42
Cleanup readthedocs to fix links and move developer content towards the bottom of the menu
@ecbland
Copy link
Author

ecbland commented Aug 2, 2021

@ksterne Can we make the release now?

@ksterne
Copy link
Contributor

ksterne commented Aug 3, 2021

Yes, though I'm not in a great position to hit the button to merge until Thursday (too many meetings). Feel free to move it along without me. I've just reviewed the checklist and added a draft release to the repo with the summary of changes that was provided. So I think we're through step 9 (we've probably indirectly reminded people on testing). For step 11, we'll want to edit the draft release to point to master and then hit publish release. I realize "draft" in this step is confusing as this was written before you could create 'draft releases'. I'll edit that here shortly.

@ecbland ecbland merged commit ed604f9 into master Aug 3, 2021
@mts299 mts299 deleted the release/rst-4.6 branch August 17, 2021 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants