-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[INTEGRATION] Improve Endpoint configuration #1653
Comments
here is the job: https://github.com/SuperDuperDB/superduperdb/actions/runs/7906999810/job/21583069571
The problem is that conftest.py effectively ignores the env variables, resulting into different configurations from CDC, Vector-search, ray-workers etc.
Here are some examples from conftest.py
Standard and Non-Standard Variables As Kartik said on a previous iteration, the reason for having non-standard variables is that we may want to test multiple databases (e.g, mongo, sql, etc). I get the problem, but we cannot simply hardcode paths because we lose portability. Possible Solution Use SUPERDUPERDB_TEST_CONFIGS that will as input a JSON of different Datalayer configuration we want to test. For example:
|
We need to improve the way we define endpoints as environment variables (and make an exhaustive list of the accepted variables).
Ideally, the testing workflow should be:
The ./deploy/testenv/endpoints should look like:
The current workflow has everything hardcoded which makes it impossible to run the tests on a kubernetes environment. For the instance, this code is always trying to connect to a local database
The text was updated successfully, but these errors were encountered: