Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update snowflake-example.md #1588

Merged
merged 2 commits into from Dec 22, 2023
Merged

Update snowflake-example.md #1588

merged 2 commits into from Dec 22, 2023

Conversation

fnikolai
Copy link
Collaborator

Description

Related Issues

Checklist

  • Is this code covered by new or existing unit tests or integration tests?
  • Did you run make unit-testing and make integration-testing successfully?
  • Do new classes, functions, methods and parameters all have docstrings?
  • Were existing docstrings updated, if necessary?
  • Was external documentation updated, if necessary?

Additional Notes or Comments

@fnikolai
Copy link
Collaborator Author

This conversion should not be the responsibility of users.
It must be done within the framework's code.

# We set this value, since Snowflake via `ibis` doesn't support `bytes` directly.
os.environ['SUPERDUPERDB_BYTES_ENCODING'] = 'Str'

fazlulkarimweb
fazlulkarimweb approved these changes Dec 22, 2023
View reviewed changes
Copy link
Collaborator

@fazlulkarimweb fazlulkarimweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On point

@fazlulkarimweb fazlulkarimweb merged commit 167996e into main Dec 22, 2023
@fazlulkarimweb fazlulkarimweb deleted the update-snowflake-example branch December 22, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fazlulkarimweb fazlulkarimweb fazlulkarimweb approved these changes

@thgnw thgnw Awaiting requested review from thgnw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fnikolai @fazlulkarimweb