Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/remove dead code #2088

Merged
merged 2 commits into from
May 23, 2024
Merged

Fix/remove dead code #2088

merged 2 commits into from
May 23, 2024

Conversation

kartik4949
Copy link
Collaborator

Description

Related Issues

Checklist

  • Is this code covered by new or existing unit tests or integration tests?
  • Did you run make unit_testing and make integration-testing successfully?
  • Do new classes, functions, methods and parameters all have docstrings?
  • Were existing docstrings updated, if necessary?
  • Was external documentation updated, if necessary?

Additional Notes or Comments

@blythed blythed force-pushed the main branch 2 times, most recently from b8748a3 to 04010cf Compare May 22, 2024 08:34
@kartik4949 kartik4949 force-pushed the fix/remove_dead_code branch 3 times, most recently from df2e292 to c7b8489 Compare May 23, 2024 13:56
jieguangzhou
jieguangzhou approved these changes May 23, 2024
View reviewed changes
superduperdb/backends/mongodb/metadata.py
out.append((r['type_id'], r['identifier']))
return out

def show_job(self, job_id: str):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a useful function, but we are missing the use cases.

superduperdb/backends/sqlalchemy/metadata.py Outdated Show resolved Hide resolved
superduperdb/ext/utils.py Outdated Show resolved Hide resolved
@kartik4949 kartik4949 merged commit 5711524 into SuperDuperDB:main May 23, 2024
3 checks passed
@kartik4949 kartik4949 deleted the fix/remove_dead_code branch May 23, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jieguangzhou jieguangzhou jieguangzhou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kartik4949 @jieguangzhou