Refactor rest server implementation #2091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blythed
force-pushed
the
rest/refactor
branch
5 times, most recently
from
9f66ccd
to
4bc35f4
Compare
blythed
force-pushed
the
rest/refactor
branch
5 times, most recently
from
faa303c
to
d91fb9c
Compare
blythed
force-pushed
the
rest/refactor
branch
3 times, most recently
from
841d57e
to
26c6a4f
Compare
| default: "*args,**kwargs" | ||
| RetrievalPrompt: | ||
| _path: superduperdb/ext/llm/prompt/RetrievalPrompt | ||
| select: |
There was a problem hiding this comment.
Here. I think the select field should be enclosed. Otherwise frontend can't render forms.
"select": {
"type": "query",
}
| identifier: | ||
| type: str | ||
| components: | ||
| type: [model, listener, vector_index] |
There was a problem hiding this comment.
type is used to define what kind of form is rendered. the type of type should be always str to render in the frontend.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make changes to make rest compatible with the new serialization protocol.
This greatly simplifies the implementation.