Selx 150 blueprint reader cannot handle two connections #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added name to connection properties
kaspermarstal
requested changes
Jan 23, 2018
| "Component": { | ||
| "Name": "ComponentB" | ||
| }, | ||
| "Connection": { |
There was a problem hiding this comment.
Nice! This style looks good
| ConnectionPropertyType | ||
| boost::multisetS, //OutEdgeList: allow multiple parallel connections | ||
| boost::vecS, // VertexList, | ||
| boost::bidirectionalS, //Directed: directed graph, but give access to traverse in both directions |
There was a problem hiding this comment.
What happens with the update order if we have a cyclic graph?
There was a problem hiding this comment.
You are right, I forgot to handle that case in this PR. Currently, we don't have cyclic graphs, but I plan to work on the CompositeTransformComponent for multistage registration were that will happen. Is it ok with you if I address handling cyclic graphs there? (I have a cyclic graph check solution in mind that addresses other expected update issues with CompositeTransformComponent as well)
kaspermarstal
approved these changes
Jan 23, 2018
FBerendsen
deleted the
SELX-150-Blueprint-reader-cannot-handle-two-connections
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blueprints are now able to have multiple parallel connections between 2 components.
To specify such connections the user must give the connections identifier names, which are by default "".
The networkbuilder was extended to handle the parallel connections.