Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect paths to KNN in elxCommon_INCLUDE_DIRECTORIES #22

Closed
N-Dekker opened this issue Aug 25, 2017 · 2 comments
Closed

Incorrect paths to KNN in elxCommon_INCLUDE_DIRECTORIES #22

N-Dekker opened this issue Aug 25, 2017 · 2 comments

Comments

@N-Dekker
Copy link
Member

https://github.com/SuperElastix/elastix/blob/develop/CMakeLists.txt#L208 says:

set( elxCommon_INCLUDE_DIRECTORIES
...
${elastix_SOURCE_DIR}/Common/KNN
${elastix_SOURCE_DIR}/Common/KNN/ann_1.1/include

These two paths are no longer there. Can they simply be removed from elxCommon_INCLUDE_DIRECTORIES?

The issue was found by CppCheck http://cppcheck.sourceforge.net which says, "Couldn't find path given by -I '...\Elastix\Common\KNN'.

By the way, KNN is currently located at elastix/Components/Metrics/KNNGraphAlphaMutualInformation
@mstaring
Copy link
Member

Hi Niels, I think these lines can be simply removed as the directories are properly included at the new location of the KNN files.
Can you create a PR?

@N-Dekker N-Dekker mentioned this issue Aug 31, 2017
Merged
FBerendsen added a commit that referenced this issue Aug 31, 2017
@FBerendsen
Merge pull request #23 from N-Dekker/develop
0827611 
COMP: Removed incorrect paths to KNN (elastix issue #22)
@mstaring
Copy link
Member

fixed by fc13390

@schmiedc schmiedc mentioned this issue Nov 21, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mstaring @N-Dekker