Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Clean up xout before rethrow #31

Merged
merged 2 commits into from
Oct 18, 2017

Commits on Oct 7, 2017

  1. BUG: Clean up xout before rethrow

    Elastix did not call AfterRegistrationBase before throwing exception
    and consequently did not clean up xout. This resulted in undefined
    behaviour and more or less random segfaults if the ElastixFilter was
    called again after an exception was thrown. This would happen _even_ if
    the filter was completely destroyed and a new filter was instantiated.
    This possibly fixes SuperElastix/SimpleElastix#123 and  an issue
    previously reported by @coertmetz but need more testing. NOTE: This
    does not change the fact that elastix is not thread safe which might
    still be an issue (also reported by @coertmetz).
    kaspermarstal committed Oct 7, 2017
    Configuration menu
    Copy the full SHA
    f1b25f1 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2017

  1. ENH: Check validity of xout before removing iteration target cell as …

    …suggestd by @coertmetz, and do it directly, instead of AfterRegistrationBase as suggested by @stefanklein
    kaspermarstal committed Oct 18, 2017
    Configuration menu
    Copy the full SHA
    a382f66 View commit details
    Browse the repository at this point in the history