Add missing parameters to transform parameter maps #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ViktorvdValk Before addressing InsightSoftwareConsortium/ITKElastix#93 and #366 I want to clean up the code of those |
N-Dekker
force-pushed
the
CreateTransformParametersMap
branch
13 times, most recently
from
caeec7f
to
b57a9a1
Compare
N-Dekker
force-pushed
the
CreateTransformParametersMap
branch
3 times, most recently
from
b78d174
to
8ec4ad7
Compare
N-Dekker
changed the title
|
@mstaring @stefanklein Can we possibly discuss this pull request at the sprint, this afternoon? |
|
lgtm |
Added three overload sets of static member functions to `BaseComponent`:
size_t GetNumberOfElements(container)
string ToString(value)
vector<string> ToVectorOfStrings(container)
Including four GoogleTest unit tests.
Made `TransformBase::CreateTransformParametersMap` non-virtual. Added transform type specific parameters by overriding the added virtual `CreateDerivedTransformParametersMap` member function, which is called by `CreateTransformParametersMap`. Reduced the amount of code duplication, by using the new `BaseComponent::ToVectorOfStrings` and `BaseComponent::ToVectorOfStrings` convenience functions. Replaced `std::map::insert` calls by `std::map::operator[]` and C++11 list initialization (using curly braces).
Added `CreateDerivedTransformParametersMap` overrides, which add missing parameters to: - AffineDTITransformElastix - AffineLogStackTransform - AffineLogTransformElastix - BSplineTransformWithDiffusion - DeformationFieldTransform - EulerStackTransform - MultiBSplineTransformWithNormal - SimilarityTransformElastix - SplineKernelTransform - TranslationStackTransform - WeightedCombinationTransformElastix Addresses the following issues: ITKElastix issue 93: "2D similarity transform parameter map doesn't keep "CenterOfRotationPoint" parameter", by Heath Patterson, 16 December, 2020. InsightSoftwareConsortium/ITKElastix#93 SuperElastix/elastix issue 366: "AffineDTITransform does not return the CenterOfRotationPoint", by dyliu2016, 27 November, 2020 #366 Declared `TransformBase::CreateDerivedTransformParametersMap()` pure virtual (`= 0`). Added an empty override to `TranslationTransformElastix`, just to keep allowing the transform to be instantiated. Extended `CreateTransformParametersMapForDefaultTransform` GoogleTest unit test. Note: Some of the overrides may still be incomplete, as indicated by comments, saying "TODO If necessary, add possibly missing parameters".
N-Dekker
force-pushed
the
CreateTransformParametersMap
branch
from
8ec4ad7
to
07bae26
Compare
N-Dekker
commented
Jan 5, 2021
Comment on lines
+1087
to
+1090
| // TODO If necessary, add possibly missing parameters: | ||
| // - "DeformationFieldFileName" (which is written by WriteToFile). | ||
| // - "GridDirection" (as returned by RecursiveBSplineTransform). | ||
| // - "ThresholdBool", "ThresholdHU", etc. (as retrieved by ReadParameter). |
There was a problem hiding this comment.
Note, still a TODO here...
N-Dekker
commented
Jan 5, 2021
Comment on lines
+719
to
+720
| // TODO If necessary, add possibly missing parameters: | ||
| // - "MultiBSplineTransformWithNormalLabels" (which is written by WriteToFile). |
There was a problem hiding this comment.
...and another TODO here!
This was referenced Jan 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.