-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "ExternalTransform" component and ElastixRegistrationMethod::SetExternalInitialTransform
#944
Conversation
Including pull request SuperElastix/elastix#944 Adds a `SetExternalInitialTransform` member function to `ElastixRegistrationMethod`, allowing to specify any ITK transform as initial transform.
Added `ObjectPtrToString(const itk::Object *)` and `StringToValue(const std::string &, const itk::Object *&)` to `elx::Conversion`, allowing lossless conversion between `std::string` and `itk::Object` pointer.
Including GoogleTest unit tests, itkTransformixFilter.ExternalTransform and ElastixRegistrationMethod.SetExternalTransformAsInitialTransform.
bfc4d1a
to
43b6380
Compare
The GitHub Actions CI failures appear unrelated to this PR:
|
Discussed with @mstaring and @stefanklein at the internal weekly elastix sprint of last Monday, 14 August. |
Including pull request SuperElastix/elastix#944 Adds a `SetExternalInitialTransform` member function to `ElastixRegistrationMethod`, allowing to specify any ITK transform as initial transform.
@mstaring @stefanklein Now that we have |
Yes, that would be useful I think!
From: Niels Dekker ***@***.***>
Sent: Thursday, August 17, 2023 1:44 PM
To: SuperElastix/elastix ***@***.***>
Cc: Stefan Klein ***@***.***>; Mention ***@***.***>
Subject: Re: [SuperElastix/elastix] Add "ExternalTransform" component and `ElastixRegistrationMethod::SetExternalInitialTransform` (PR #944)
Waarschuwing: Deze e-mail is afkomstig van buiten de organisatie. Klik niet op links en open geen bijlagen, tenzij u de afzender herkent en weet dat de inhoud veilig is.
Caution: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe.
@mstaring<https://github.com/mstaring> @stefanklein<https://github.com/stefanklein> Now that we have ElastixRegistrationMethod::SetExternalInitialTransform, would it be useful to add a "SetExternalTransform" member function to TransformixFilter as well? TransformixFilter already has a SetTransform that accepts an ITK transform as input. But only if it can be converted to an existing elastix component (Translation, Affine, Euler, Similarity, Bspline). TransformixFilter::SetExternalTransform would support any arbitrary ITK transform.
-
Reply to this email directly, view it on GitHub<#944 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAF2LNLWKUFB7ZX3WCR3XUDXVX7X7ANCNFSM6AAAAAA3LFCHRI>.
You are receiving this because you were mentioned.Message ID: ***@***.******@***.***>>
|
good idea!
…________________________________
From: Stefan Klein ***@***.***>
Sent: 17 August 2023 13:46
To: SuperElastix/elastix ***@***.***>
Cc: Staring, M. (RADI) ***@***.***>; Mention ***@***.***>
Subject: Re: [SuperElastix/elastix] Add "ExternalTransform" component and `ElastixRegistrationMethod::SetExternalInitialTransform` (PR #944)
Yes, that would be useful I think!
From: Niels Dekker ***@***.***>
Sent: Thursday, August 17, 2023 1:44 PM
To: SuperElastix/elastix ***@***.***>
Cc: Stefan Klein ***@***.***>; Mention ***@***.***>
Subject: Re: [SuperElastix/elastix] Add "ExternalTransform" component and `ElastixRegistrationMethod::SetExternalInitialTransform` (PR #944)
Waarschuwing: Deze e-mail is afkomstig van buiten de organisatie. Klik niet op links en open geen bijlagen, tenzij u de afzender herkent en weet dat de inhoud veilig is.
Caution: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe.
@mstaring<https://github.com/mstaring> @stefanklein<https://github.com/stefanklein> Now that we have ElastixRegistrationMethod::SetExternalInitialTransform, would it be useful to add a "SetExternalTransform" member function to TransformixFilter as well? TransformixFilter already has a SetTransform that accepts an ITK transform as input. But only if it can be converted to an existing elastix component (Translation, Affine, Euler, Similarity, Bspline). TransformixFilter::SetExternalTransform would support any arbitrary ITK transform.
-
Reply to this email directly, view it on GitHub<#944 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAF2LNLWKUFB7ZX3WCR3XUDXVX7X7ANCNFSM6AAAAAA3LFCHRI>.
You are receiving this because you were mentioned.Message ID: ***@***.******@***.***>>
—
Reply to this email directly, view it on GitHub<#944 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAFRMFC4MAZM5HVTIZ6KBBTXVX77TANCNFSM6AAAAAA3LFCHRI>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Here it is, the |
Adds a component that allows specifying an ITK transform by its address in memory. The transform is then not converted to the corresponding elastix AdvancedTransform. Instead, it is only "adapted", meaning that its
TransformPoint
is still called directly, when using the transform. This component is only meant to be used with the elastix/transformix library, not with the elastix/transformix executable. It only serves as input transform, so it is meant not to be adjusted during registration.Adds a
SetExternalInitialTransform
member function toElastixRegistrationMethod
, allowing to specify any ITK transform (for example anitk::DisplacementFieldTransform
) as initial transform. Aims to address the following issue:DisplacementFieldTransform
as input to library interface #874