Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP Send Problems #141

Closed
amwtech opened this issue Apr 30, 2023 · 3 comments
Closed

HTTP Send Problems #141

amwtech opened this issue Apr 30, 2023 · 3 comments
Labels
bug Something isn't working Done? (to be verified) Waiting for OP to verify that the fix works

Comments

@amwtech
Copy link

amwtech commented Apr 30, 2023

I have encountered two issues with the http send device:

  1. Unable to delete a parameter, the delete bin for the parameter number only deletes the key value, not the Parameter
  2. The only key name that works for data entry is of the form param0 meaning the tool can not send to most restful APIs

To Reproduce Parameter Delete issue

  1. Add an HTTP Send device to the local bridge. The name field does not matter
  2. Add an HTTP Request to a part.
  3. Click the ADD PARAMETER button.
  4. Click on the red bin item at the right of the Param # line. The value field clears.

Expected behavior
To be able to remove the parameter complete with its key and value settings.

To Reproduce Parameter Name issue

  1. Add an HTTP Send device to the local bridge if there is not one already present.
  2. Add an HTTP Request to a part.
  3. Click the ADD PARAMETER button. The blank entry form for the parameter is shown as below.

HTTP Send Blank Parameter

  1. Click on the Key field and change the name. For example enter the key name of action, then tab to the value entry field. The entry form changes to the style illustrated below.

HTTP Send Key name issue

The extra parameter entry elements are shown.

Expected behavior
To enter user specified parameter names such that external equipment with a restful api can be sent a control message. For example:

http://192.168.100.101:80/config?action=set&paramid=eParamID_VideoInSelect&value=0

Test Environment:
macOS version 12.6.5 running SuperConductor version 0.11.0-alpha.3

@amwtech amwtech added the bug Something isn't working label Apr 30, 2023
nytamin added a commit that referenced this issue May 3, 2023
@nytamin
Copy link
Member

nytamin commented May 3, 2023

Thanks!
This will be fixed in the next (pre-)release

@nytamin nytamin added the Done? (to be verified) Waiting for OP to verify that the fix works label May 3, 2023
@amwtech
Copy link
Author

amwtech commented May 3, 2023

Johan,
Thanks for the feedback. I have since seen a similar error that you may already have fixed whilst looking at issue #144.

If you add a parameter placeholder to an HTML template item, a key/value parameter cannot be removed by using the red dustbin on the parameter. I intended to add just one key/value pair but accidentally added two, then I was unable to delete either.

Andy

@nytamin
Copy link
Member

nytamin commented May 4, 2023

Ah, yeah that's a good observation too!

I've made a fix for that as well, it'll be in v0.11.0-alpha.4

@nytamin nytamin closed this as completed May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Done? (to be verified) Waiting for OP to verify that the fix works
Projects
None yet
Development

No branches or pull requests

2 participants