-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for HyperDeck devices #71
Conversation
This was here as part of a hack that I forgot to remove.
The linter errors are due to TSR not being updated yet and should go away once we have an appropriate nightly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Could you go through the list below, then I'd be happy to merge this:
- Adress the review comment
- Update TSR dependency to
7.3.0-nightly-release44-20220914-085659-53fbc9650.0
, which contains the hyperdeck-PR - Test that it works and builds
- Update README
- Set this PR to "ready to review" and re-request a review from me :)
|
Ah my mistake, try this one instead: 7.4.0-nightly-release46-20220915-075618-de36c07ee.0 |
I'm not sure why, but uncaught exceptions are being thrown whenever the sideload connection fails to connect or times out. Below is an example:
I'm not sure where the problem lies. Is it an issue with |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Whoops, you can ignore this. I had simply forgotten to rebuild the shared packages before testing a change. |
This PR adds support for the following HyperDeck commands:
"Stop" is implicit and is defined as the absence of any of the above commands.
The other commands (Forward, Rewind, Jog, and Shuttle) really only make sense for manual control of the device and are unlikely to be supported. Fast forward and rewind functionality can already be achieved via the
speed
parameter of the Play command.This branch has been tested extensively and is currently being used in a live production.
This PR will be ready to merge once nrkno/sofie-timeline-state-resolver#213 is merged and a new nightly release is available (if we're okay using a nightly release of TSR, that is).