open_esplibs libnet80211: source code for sdk_wifi_softap_start paths. #286
Conversation
The function sdk_wifi_softap_start is one of two paths that allocates a struct netif and also accesses the netif->hwaddr so is needed for lwip development. This function depends on static data and functions so a good bit so other code was needed.
|
By the way, some of decompiled net80211 functions can be found at https://github.com/ernacktob/esp8266_wifi_raw |
There was a problem hiding this comment.
@ourairquality How much testing have you done of this code?
I think we should merge it even if we can't be sure it doesn't have a regression. We can always disable parts of open_esplibs to check if some issue appears.
Thanks for the great work!
|
@sheinz Testing is limited, it appears to work in all the code I am working with, but some of these functions were a struggle to translate by hand so I would like to re-check them. Very hard to review these. I am exploring some automation to help translate the code, it still needs a lot of manual work, but might give a different view for comparison. Still need to get the wl_cnx.o translated for lwip v2 to be practical, which could take time, so there is no rush on this PR. |
|
Have been over this many times so hope it is all ok, and it was necessary to bundle it in with the lwip v2 support #389 so closing this PR. |
The function sdk_wifi_softap_start is one of two paths that allocates a struct netif and also accesses the netif->hwaddr so is needed for lwip development. This function depends on static data and functions so a good bit so other code was needed.
This was a difficult set, challenging to review, but it gets us the allocation of the netif structure needed for LwIP development, plus the remaining uses of the ets_timer, so feedback welcomed.