Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

red/blue colors inverted #42

Closed
DiViNiTY002 opened this issue Jan 9, 2023 · 7 comments
Closed

red/blue colors inverted #42

DiViNiTY002 opened this issue Jan 9, 2023 · 7 comments
Labels
bug Something isn't working

Comments

@DiViNiTY002
Copy link

the red and blue colors are inverted when running DOjS in 32 Bit mode ("-b 32") with a "mpeg" video.

@SuperIlu
Copy link
Owner

SuperIlu commented Jan 9, 2023

Thanks for reporting, I'll check that with my test videos.
Can you provide the JSLOG.TXT?

@SuperIlu SuperIlu added the bug Something isn't working label Jan 9, 2023
@DiViNiTY002
Copy link
Author

DOJS.EXE -r -w 320 -b 32 -f -t EXAMPLES\DIVINITY.JS

-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
DOjS V1.9.1 (Dec 18 2022 16:26:10) starting with file EXAMPLES\DIVINITY.JS
Mouse detected
Sound output: PCM[Sound Blaster 16; SB 16 (22727 hz) on port 220, using IRQ 7 and DMA channel 5; 64], FM[; The sound of silence; 65535]
Sound input: OK
GLIDE3X.DXE missing, please run one of the V_x.BAT scripts to get the driver matching your hardware! All 3dfx functions are disabled!
Joystick found.
TCP/IP stack disabled
Screen size: 320x240x32
Memory: {}
Long file names: false
Command line args: ["EXAMPLES\DIVINITY.JS"]
SerialPorts: ["0x3f8","0x2f8"]
ParallelPorts: ["0x378"]
FDD: 1, HDD: 2
init_gifanim
init_mpeg1
init_png
init_vorbis
DOjS Shutdown...

I think there is nothing special in the log file. I really like DOjS, especially the "mpeg1" and "ogg vorbis" features and that it is Javascript.

@SuperIlu
Copy link
Owner

SuperIlu commented Jan 9, 2023

Oh my Goth, I'm laughing so hard right now about myself: https://mastodon.social/@dec_hl/109661409199629143

@SuperIlu SuperIlu added this to the v1.10.0 release milestone Jan 10, 2023
@SuperIlu
Copy link
Owner

Ok, I found and fixed it. Fix will be part of the upcoming v1.10.
I won't promise on a release date, so if you want a preliminary release give me a nudge and I'll upload one...

@DiViNiTY002
Copy link
Author

Thanks a lot! You could update the Source code (only if you want to), i can compile DOjS by myself or i wait for the next release. :)

@SuperIlu
Copy link
Owner

pushing the current state is the same work as a new release. :)

if you want to compile, open plugins/mpeg1.dxelib/mpeg1.c, head to MPEG1_video_decode_callback() and change

plm_frame_to_rgba(frame, (uint8_t *)m->video_buffer->dat, frame->width * sizeof(uint32_t));

into

plm_frame_to_bgra(frame, (uint8_t *)m->video_buffer->dat, frame->width * sizeof(uint32_t));

@SuperIlu SuperIlu reopened this Jan 10, 2023
@SuperIlu
Copy link
Owner

fixed in v1.10.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants