Skip to content

Commit

Permalink
Set listen not only on localhost when used in docker
Browse files Browse the repository at this point in the history
When puma was introduced in diaspora#8392 the default listen configuration was
set to only localhost, which makes sense for most development setups,
but when run within docker, it needs to listen on all IPs so the port
can be forwarded to be accessable outside of docker.

Because the new default makes sense without docker, I overwrite the
option with a environment variable only in the docker-setup. This also
ensures that it always contains the right value needed for the
docker-setup to work, no matter what was configured outside of docker.
  • Loading branch information
SuperTux88 committed Sep 19, 2022
1 parent 84df8ee commit a4d4535
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions docker/develop/docker-compose.yml
Expand Up @@ -24,6 +24,7 @@ services:
- ${DIASPORA_DOCKER_PORT:-3000}:3000
environment:
- ENVIRONMENT_REDIS=redis://redis
- SERVER_LISTEN=tcp://0.0.0.0:3000
depends_on:
- "${DIASPORA_DOCKER_DB}"
- redis
Expand Down

0 comments on commit a4d4535

Please sign in to comment.