Delete recursively all objects before deleteDir #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What is the status of this PR? We are needing this as we move from AWS to GCS to allow expected behavior. Thanks so much to everyone for doing this work! |
Closed
LiamNorman
approved these changes
Feb 7, 2019
|
Thanks @kainxspirits, looks great! We are going to release this soon 👍 |
nicja
approved these changes
Feb 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #92, it will delete all objects inside the dirrectory before deleting the directory itself. Actually the directory are not removed at all if there is something inside it.
Also altered the tests since we now expect a different behavior.