Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Larval 5.6 Issues #4

Open
matthewscalf opened this issue Mar 10, 2018 · 2 comments
Open

Larval 5.6 Issues #4

matthewscalf opened this issue Mar 10, 2018 · 2 comments
Assignees

Comments

@matthewscalf
Copy link

Getting this after upgrading Laravel:

Symfony\Component\Debug\Exception\FatalErrorException: Declaration of Superbalist\AjaxRedirector\AjaxRedirectResponse::isRedirect($location = NULL) must be compatible with Symfony\Component\HttpFoundation\Response::isRedirect(?string $location = NULL): bool
File "vendor/superbalist/laravel-ajax-redirector/src/AjaxRedirectResponse.php

Any chance of providing an update?

@etiennemarais
Copy link

Laravel started supporting PHP return types from 5.5.x (source) by using PHP 7.x.

Version branch 2.0.0 of this library seems to support older versions of PHP so it feels like we have to make a PR to bring in support for PHP return types.

We could make a v3.0.x branch/tag where we add support for Laravel versions upwards and including 5.5 (see source link ^^)

If you don't mind making a pull request, I will spend some time making the releases etc. That sound okay @matthewscalf ?

@etiennemarais etiennemarais self-assigned this Mar 12, 2018
@elanclarkson
Copy link

PR #5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants