Allow configuring the disk's visibility and cache as with S3 #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgoguerra
changed the title
|
Thank you 👍 |
|
Been a while :). Has this been released by any chance? |
|
Hi @mkarnicki Unfortunately @matthewgoslett and I don't work at the company responsible for this library any more, but since this PR hasn't been merged yet, I doubt it's been released. |
|
Thank you for replying @zoidbergwill , have a great day. |
|
This would be great |
nicja
approved these changes
Dec 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows configuring the optional
visibility,disable_assertsandurloptions on the filesystem, as well as adding a caching layer around the adapter.The main benefit of this would be to be able to configure the disk's visibility the same way as if using a S3 disk.
See: Laravel's FilesystemManager::createFlysystem().