Replace abandoned Jimdo/prometheus_client_php dependency #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hing/prometheus_client_php
|
@bradsuperbalist please make an attention to this PR. The jimdo/prometheus_client_php package marked as abandoned from now and this blocking install laravel-prometheus-exporter library. |
|
https://github.com/endclothing/prometheus_client_php has a minimum requirement of PHP 7.2, in order for this to work the minimum requirement for PHP in |
|
Closing this in favor of #22. Sorry I neglected this MR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the issue #11:
https://github.com/Jimdo/prometheus_client_php is archived and no longer maintained.
They didn't add the
abandonedvalue incomposer.json, so there's no link to it from there, but they linked to this repository in the readme: https://github.com/endclothing/prometheus_client_php .This changes the dependency accordingly.
This will bump the required minimum PHP Version to 7.1.
Closes #11