Adds support for PHP >= 7.2 and switch to endclothing/prometheus_client_php #22
Conversation
… for all PHP versions prior to 7.2 and replace jimdo/prometheus_client_php with endclothing/prometheus_client_php to support PHP 7.2.
|
Just for context, I know an existing PR for these changes exists (#15) however, it hasn't been updated to ensure that the existing tests pass so I opted to open this MR instead in favour of the other. |
|
Hey @FutureMatt, i would recommend switching to https://github.com/LKaemmerling/prometheus_client_php instead of endclothings as it looks like endclothing does not maintain there fork anymore. This would also allow preparation for Laravel 8, as endclothings fork doesn't work with recent Guzzle releases. |
* Updated the composer.json to require PHP 7.2, removed Travis CI tests for all PHP versions prior to 7.2 and replace jimdo/prometheus_client_php with endclothing/prometheus_client_php to support PHP 7.2. * Updated PHPUnit to v8 and Mockery to v1.4 in order to support PHP 7.4. * Downgraded Mockery from 1.4 to 1.3 in order to support PHP versions < 7.3.
Updated composer.json to alter the package name to match the Git repo.
* PHP 7.2+ Support * Updated the composer.json to require PHP 7.2, removed Travis CI tests for all PHP versions prior to 7.2 and replace jimdo/prometheus_client_php with endclothing/prometheus_client_php to support PHP 7.2. * Updated PHPUnit to v8 and Mockery to v1.4 in order to support PHP 7.4. * Downgraded Mockery from 1.4 to 1.3 in order to support PHP versions < 7.3. * Updated composer.json to allow laravel ^8.0 Co-authored-by: FutureMatt <43476243+FutureMatt@users.noreply.github.com>
|
Hi @nicja and all, I know we're all kind of busy with work and the current crazyness - but just wondering if there is any rough idea if this will get merged or something else done to allow for newer Laravel versions? Even a rough 'in a month or so' would be helpful. I'd hate to fork it if there's going to be some activity on the repo sometime to do the same work. |
|
unfortunately i am no longer admin on this repo @bertuss @nikolaos-spyratos |
|
@bertuss @nikolaos-spyratos Any possibility to push this through? That would be really helpful! |
|
FYI there is now a "semi-official" client library: https://github.com/PromPHP/prometheus_client_php This client library is based on the endclothing client, so using it as a drop-in releasement is completely fine. |
This MR switches the required Prometheus Client package from jimdo/prometheus_client_php to endclothing/prometheus_client_php.
All support for versions of PHP prior to 7.2 are dropped in this MR.
Also the minimum required version of PHPUnit is now 8.0 and mockery is 1.3. This was done in order to support PHP 7.4. These aren't the latest versions of the testing packages as those drop support for versions on PHP < 7.3 so in order to maximize compatibility with 7.x versions of PHP I opted for slightly older versions.