Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgradable contracts using set_code_hash function #2

Closed
wants to merge 10 commits into from
Closed

Upgradable contracts using set_code_hash function #2

wants to merge 10 commits into from

Conversation

yarikbratashchuk
Copy link

@yarikbratashchuk yarikbratashchuk commented Dec 29, 2021 •
edited
Loading

Implementation for #10567

@yarikbratashchuk yarikbratashchuk self-assigned this Dec 29, 2021
@yarikbratashchuk yarikbratashchuk changed the title Upgradable contracts using set_code_hash function POC Upgradable contracts using set_code_hash function Jan 11, 2022
VargSupercolony
VargSupercolony approved these changes Jan 11, 2022
View reviewed changes
Copy link

@VargSupercolony VargSupercolony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add set_code_hash function, add benchmarks & weights

xgreenx
xgreenx reviewed Jan 11, 2022
View reviewed changes
frame/contracts/fixtures/set_code_hash.wat Outdated Show resolved Hide resolved
frame/contracts/src/exec.rs Outdated Show resolved Hide resolved
frame/contracts/src/tests.rs Outdated Show resolved Hide resolved
@xgreenx xgreenx mentioned this pull request Jan 17, 2022
Closed
@yarikbratashchuk
Revert unrelated change
a4c479c
@yarikbratashchuk
Changes due to @athei's review
e36d5e5
@yarikbratashchuk
Fix error handling
a5a3ec8 
- comment errors: ReturnCodes
- update mock ext implementation
- return Error::CodeNotFound when no code for such hash
@yarikbratashchuk
Emit ContractCodeUpdated when setting new code_hash
01987ea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VargSupercolony VargSupercolony VargSupercolony approved these changes

@sventime sventime Awaiting requested review from sventime

@xgreenx xgreenx Awaiting requested review from xgreenx

Assignees

@yarikbratashchuk yarikbratashchuk

Labels
A0-pleasereview
Projects
None yet
Milestone
No milestone
3 participants
@yarikbratashchuk @xgreenx @VargSupercolony