Skip to content
This repository has been archived by the owner on Nov 15, 2022. It is now read-only.

Implement _encode_entity for Python 2.7 #5

Closed
mnaberez opened this issue Nov 27, 2012 · 5 comments
Closed

Implement _encode_entity for Python 2.7 #5

mnaberez opened this issue Nov 27, 2012 · 5 comments

Comments

@mnaberez
Copy link
Member

Pull request #4 fixed a bug where _encode_entity was used by the code but not being imported.

On Python 2.7, this method was removed (we also had this problem with fixtag). The patch in #4 defines it as a no-op but we should put in an actual implementation.

@puentesarrin
Copy link
Contributor

Can I port the code from 2.5/2.6 and send the pull-request?

@mnaberez
Copy link
Member Author

Absolutely. Thanks!

@mnaberez
Copy link
Member Author

I tweaked this a little in 0738881 to remove the check for Python 1.5, since meld3 doesn't work on that version.

It's unfortunate that the tests did not catch the problem you originally reported in #4. Do you have some sample input that we can add to test_meld3.py to make sure we don't break it again?

@puentesarrin
Copy link
Contributor

Simply test with any character with accent, such as: "á" or "é".

@puentesarrin
Copy link
Contributor

Excelent! @mnaberez thanks for merge.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

2 participants