Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Location header change domain if behind a proxy server #1013

Closed
krocos opened this issue Nov 6, 2017 · 2 comments
Closed

Location header change domain if behind a proxy server #1013

krocos opened this issue Nov 6, 2017 · 2 comments

Comments

@krocos
Copy link

krocos commented Nov 6, 2017

I have the next scheme of proxying:
[proxy] -> [service with supervisor]
And if I call in browser mydomain.com the proxy service do proxy pass to the "supervisor" domain name, and it's ok. But if the supervisor service sends back a Location header I get in browser domain "supervisor" instead of mydomain.com.
I think we need to remove the server_url var here:
https://github.com/Supervisor/supervisor/blob/master/supervisor/web.py#L475

@krocos
Copy link
Author

krocos commented Nov 6, 2017

For example on the refresh action I get back that Location header:
Location: http://supervisor:9001?message=Page%20refreshed%20at%20Mon%20Nov%20%206%2013%3A21%3A06%202017

instead of

Location: /?message=Page%20refreshed%20at%20Mon%20Nov%20%206%2013%3A21%3A06%202017

@mnaberez
Copy link
Member

mnaberez commented Nov 6, 2017

Duplicate of #29

@mnaberez mnaberez marked this as a duplicate of #29 Nov 6, 2017
@mnaberez mnaberez closed this as completed Nov 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants