Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flag to disable stdout logging for non daemonized instances #1301

Merged
merged 6 commits into from
Dec 8, 2019

Conversation

terev
Copy link
Contributor

@terev terev commented Dec 2, 2019

Added a new flag to disable logging to stdout for non daemonized instances. This is of use in a dockerized env where filebeat is being used to pump log files (including supervisord) to stdout in a standard format. Without this flag there are duplicated log entries written to stdout.

Closes #661

@terev
Copy link
Contributor Author

terev commented Dec 7, 2019

@mnaberez any chance someone could have a look at this? i'm very happy to add more tests and add to the documentation

Copy link
Member

@mnaberez mnaberez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Let’s call it --silent so it’s -s/--silent instead of -s/--quiet.
  • Tests need to verify behavior on and off.
  • Needs to be at the top supervisord.py (for --help).
  • Add it to skel/sample.conf.
  • Mention it on the configuration page of the docs.

@terev terev requested a review from mnaberez December 8, 2019 07:12
@mnaberez mnaberez merged commit 3e7c082 into Supervisor:master Dec 8, 2019
@mnaberez
Copy link
Member

mnaberez commented Dec 8, 2019

Thanks for the patch and follow-up work!

@terev
Copy link
Contributor Author

terev commented Dec 9, 2019

Np! Thank you for helping to maintain an awesome project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

disable supervisor logs to stdout/stderr
2 participants