Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Append timestamps to logs #1349

Closed
wants to merge 5 commits into from
Closed

Append timestamps to logs #1349

wants to merge 5 commits into from

Conversation

axil
Copy link

@axil axil commented May 21, 2020

This is the second advent of PR #333

@@ -571,6 +571,7 @@ def test_options(self):
self.assertEqual(proc1.startretries, 10)
self.assertEqual(proc1.uid, 0)
self.assertEqual(proc1.stdout_logfile, '/tmp/cat.log')
self.assertEqual(proc1.stdout_append_timestamp,False)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

,space

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@mnaberez
Copy link
Member

This is the second advent of PR #333

Please don't open exact duplicates of existing PRs that have been closed.

@mnaberez mnaberez closed this May 26, 2020
@axil
Copy link
Author

axil commented May 26, 2020

@mnaberez That PR was closed due to inactivity because noone was willing to fix obvious errors in it. Well, I did fix them.

This feature (#553) is still open and eagerly sought for.

If you have any objections to the patch itself, please clarify them.

@mnaberez
Copy link
Member

If you have any objections to the patch itself, please clarify them.

#333 (comment)

@mnaberez mnaberez reopened this May 26, 2020
@polmonso
Copy link

@axil will you have time to add the tests? I might give it a go if I find a moment

@mnaberez
Copy link
Member

Closing due to inactivity. Original request #553 will remain open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants