change webui action response to use referring url instead of server url for location header #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this patch but we shouldn't depend on the referrer in this way. It may not be sent by the browser. However, we should have a solution for this. I've created a new issue #29 for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the supervisor web ui is deployed at a subdirectory (instead of a virtual host), the user is redirected to the wrong url when an action response is received. The location header requires an absolute url, and the HTTP_HOST was being used to construct this url. Using referring url instead (after dropping the query part of the url) ensures that the user is redirected to the appropriate page.