This repository has been archived by the owner on Dec 14, 2020. It is now read-only.
Don't split on empty folded headers #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Minimizes behaviour differences with 2-4 stable - Not allowing spaces on gap line breaks rspec ./spec/mail/message_spec.rb:274 # Mail::Message accepting a plain text string email should give allow for whitespace on the gap line between header and body Conflicts: spec/monkeys/message_spec.rb
RFC conformant mails have an empty line separating headers and body http://tools.ietf.org/html/rfc2822#section-3.5 message = (fields / obs-fields) [CRLF body]
| # http://tools.ietf.org/html/rfc2822#section-3.5 | ||
| # Added to minimize behaviour differences with 2-4 stable, and to not break | ||
| # rspec ./spec/mail/message_spec.rb:274 # Mail::Message accepting a plain text string email should give allow for whitespace on the gap line between header and body | ||
| it 'allows 2 or more whitespaces on the gap line between header and body' do |
There was a problem hiding this comment.
@avinasha Allowing 2 or more whitespaces on the gap line, closer to 2-4 stable which allows 1 or more whitespaces on the gap line. Or should we strictly stick to RFC, and only split on \r\n\r\n?
There was a problem hiding this comment.
Importing a corrupt mail is better than not importing, being non strict
nisanthchunduru
added a commit
that referenced
this pull request
Jul 2, 2014
Don't split on empty folded headers
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/SupportBee/SupportBee-Rails/pull/808