Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date formatting #36

Closed
tgandrews opened this issue Apr 18, 2018 · 3 comments
Closed

Date formatting #36

tgandrews opened this issue Apr 18, 2018 · 3 comments

Comments

@tgandrews
Copy link
Contributor

Currently this imports date-fns library even if it is never used. As the formatter can be provided could this removed so that it doesnt add to bundles when never used. I appreciate this is a breaking change but the workaround is very small and makes the dependency more explicit.

@SupremeTechnopriest
Copy link
Owner

I could make it so you supply your own format function, or just get the date back raw. Thats not a bad idea.

@tgandrews
Copy link
Contributor Author

tgandrews commented Apr 19, 2018 via email

@SupremeTechnopriest
Copy link
Owner

SupremeTechnopriest commented Apr 19, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants