-
-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Date formatting #36
Comments
I could make it so you supply your own format function, or just get the date back raw. Thats not a bad idea. |
Do you want me to open a PR?
…On Wed, 18 Apr 2018 at 20:10, Randy Lebeau ***@***.***> wrote:
I could make it so you supply your own format function, or just get the
date back raw. Thats not a bad idea.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#36 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AALCpy9LaQiz0kA3ktP3jrB7ivHs_-07ks5tp4-MgaJpZM4TaJ0y>
.
|
If you don't mind. I'm exceptionally busy the next few weeks. Appreciate
it!
…On Thu, Apr 19, 2018, 4:14 AM Tom Andrews ***@***.***> wrote:
Do you want me to open a PR?
On Wed, 18 Apr 2018 at 20:10, Randy Lebeau ***@***.***>
wrote:
> I could make it so you supply your own format function, or just get the
> date back raw. Thats not a bad idea.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <
#36 (comment)
>,
> or mute the thread
> <
https://github.com/notifications/unsubscribe-auth/AALCpy9LaQiz0kA3ktP3jrB7ivHs_-07ks5tp4-MgaJpZM4TaJ0y
>
> .
>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#36 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACKCXiTgJnQkIU-xeNwV6IRIBHLTr_D5ks5tqEd3gaJpZM4TaJ0y>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently this imports date-fns library even if it is never used. As the formatter can be provided could this removed so that it doesnt add to bundles when never used. I appreciate this is a breaking change but the workaround is very small and makes the dependency more explicit.
The text was updated successfully, but these errors were encountered: