Added a 'listfacts' command to the Infobot plugin. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changing the sqlite version requires more extensive changes to Supybot proper. The old library is still available and a conversion is on my roadmap for Supybot, but I haven't had a chance to do it yet. Also, the sqlite2 and sqlite3 databases aren't compatible, so more care needs to be taken when the conversion does take place so I'd prefer not to include that yet. |
| @@ -229,6 +229,11 @@ class PickleInfobotDB(object): | |||
| ((Is, Are), _) = self._getDb(channel) | |||
| return len(Are.keys()) + len(Is.keys()) | |||
|
|
|||
| def getFacts(self, channel, partial): | |||
| ((Is, Are), _) = self._getDb(channel) | |||
| return '[' + ', '.join(Are.keys()) + '], [' + ', '.join(Is.keys()) + ']' | |||
There was a problem hiding this comment.
Using string formatting is preferred over string concatenation. Using Supybot's utils.str library would be useful here:
return utils.str.format('[%L], [%L]', Are.keys(), Is.Keys())
jamessan
added a commit
that referenced
this pull request
Jun 18, 2013
Closes #1 Signed-off-by: James McCoy <vega.james@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ostensibly this should have been a fairly minor change, requiring only three new functions: one in each of the DB classes (pickle and sqlite) called 'getFacts'; and one in the main Infobot class called 'listfacts'. The pickle DB and Infobot changes were indeed trivial. However the sqlite change was major - replacing an apparently old library (sqlite) with the modern sqlite3 - in turn requiring considerable modification to the sqlite DB class.
I tested:
I was unable to test:
Fair enough if you don't want to merge the sqlite changes.