Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config Checking #20

Merged
merged 1 commit into from
Oct 11, 2021
Merged

Config Checking #20

merged 1 commit into from
Oct 11, 2021

Conversation

ooliver1
Copy link
Contributor

@ooliver1 ooliver1 commented Oct 11, 2021 •
edited

closes #9

has been tested with incorrect VALID_CONFIG and also invalid config.json 's

@huenique huenique added hacktoberfest-accepted Valid PR for hacktoberfest enhancement New feature or request labels Oct 11, 2021
huenique
huenique approved these changes Oct 11, 2021
View reviewed changes
Copy link
Member

@huenique huenique left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! thanks!

@huenique huenique merged commit 61fafe7 into SurPathHub:main Oct 11, 2021
@ooliver1 ooliver1 deleted the config-checking branch October 11, 2021 18:04
@ooliver1 ooliver1 restored the config-checking branch October 11, 2021 18:04
@ooliver1 ooliver1 deleted the config-checking branch October 11, 2021 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huenique huenique huenique approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request hacktoberfest-accepted Valid PR for hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement configuration checking
2 participants
@ooliver1 @huenique