-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addition of end command and greetings.py #3
Conversation
Almost there, just need to go over the syntax/code guideline. It's kinda important that we identify and resolve any syntax and style issues. Could you run
Then try running flake8 and pylint
|
Will do that, thanks. |
if there are issues, changes should be made and committed. something like "refactor: enforce code style" should be enough. thanks |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes in the README file aren't quite right.
5. Run poetry shell. This will create a virtual environment and finds the pyproject.toml in the current directory.
6. Run poetry install. This will install all the dependencies listed in poetry.lock.
Number 5 doesn't make sense here. When poetry is run with the shell
argument, it first finds the pyproject.toml file and creates the virtual environment based on that. However, if a virtual environment already exists for said file, it only needs to start it.
Number 6 is missing a few details but I don't suggest adding them. The pyproject.toml file designates the dayong directory as a package (name = "dayong"
), hence everything inside it will be installed in the dist-packages or site-packages when poetry install
is run. For the package dependencies, poetry installs everything in the poetry.lock file, but if that file doesn't exist, it uses pyproject.toml and then generates poetry.lock.
For now, I think it's best to revert the changes made to the README. Since it seems opinionated, I'd like to add my two cents. I prefer keeping it short and simple. Moreover, it's really not necessary for the reader to immediately know how poetry works as it isn't totally related. If they are interested, poetry's repository is already linked.
only remaining issue is with the readme file, everything else looks good. will merge once resolved 🙏 |
I've already edited the README, thanks for your correction 😊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
really well done ✨
End Command in utils.py
Test.py