Skip to content
This repository has been archived by the owner on Dec 18, 2023. It is now read-only.

Added tests for Stop, Start and Use #74

Merged
merged 6 commits into from
Oct 2, 2022

Conversation

Du-z
Copy link
Collaborator

@Du-z Du-z commented Sep 30, 2022

The Rest connection now throws when try to use it with unset credentials. This is to try and keep it consistent with RPC.

Also switched the round trip tests to use a static date time and commented them out due to them failing from the prepended 00 issue.

@Du-z
Copy link
Collaborator Author

Du-z commented Sep 30, 2022

Looks like nightly isn't keen with the connection being closed.

@Du-z
Copy link
Collaborator Author

Du-z commented Oct 2, 2022

@ProphetLamb is it possible to make the builds not cancel when one encounters an error?

Previously the nightlies would fail, and the standard builds would get canceled. It makes it hard to draw conclusions if it is an issue with the nightly build or all builds.

@ProphetLamb
Copy link
Collaborator

@Du-z addling fail-fast: false to the matrix solves this

Copy link
Collaborator

@ProphetLamb ProphetLamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for figuring the cancellation out, that's a huge help! <3

@ProphetLamb ProphetLamb merged commit 5123458 into master Oct 2, 2022
@ProphetLamb ProphetLamb deleted the feature/more_db_operations_tests branch October 2, 2022 06:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants