Skip to content

Commit

Permalink
Merge pull request kserve#15 from yuzisun/contributor
Browse files Browse the repository at this point in the history
Add doc contributor guide
  • Loading branch information
yuzisun committed Sep 13, 2021
2 parents b8ba587 + 22cfd25 commit fe72a21
Show file tree
Hide file tree
Showing 11 changed files with 1,406 additions and 0 deletions.
6 changes: 6 additions & 0 deletions OWNERS
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
approvers:
- yuzisun
- theofpa
reviewers:
- yuzisun
- theofpa
76 changes: 76 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
@@ -1 +1,77 @@
# KServe documentation

Welcome to the source file repository for our documentation on
https://kserve.io.

## Website

The KServe documentation website is built using [Material for MkDocs](https://squidfunk.github.io/mkdocs-material/).

### View published documentation

View all KServe documentation and walk-through our code samples on the
[website](https://kserve.io).

The KServe website includes versioned docs for recent releases, the KServe
blog, links to all community resources, as well as KServe governance and
contributor guidelines.

### Run website locally

For instructions, see KServe's [MkDocs contributor guide](docs/help/contributor/mkdocs-contributor-guide).

### Website source files

Source files for the documentation on the website are located within the
[`/docs`](docs) directory of this repo.

### Documentation versions for KServe releases

Each release of the KServe docs is available in the website (starting with
0.3) and their source files are all stored in
[branches of this repo](doc-releases.md).

## Contributing to docs

We're excited that you're interested in contributing to the KServe documentation! Check out the resources below to get started.

### Getting started

If you want to contribute a fix or add new content to the documentation, you can
navigate through the [`/docs`](docs) repo or use the `Edit this page` pencil icon on each of the pages of
the website.

Before you can contribute, first start by reading the KServe contributor
guidelines and learning about our community and requirements. In addition to
reading about how to contribute to the docs, you should take a moment to learn
about the KServe code of conduct, governance, values, and the KServe working
groups and committees.

[KServe community and contributor guidelines](docs/community/contributing/)

Source files for all KServe community and governance topics are located
separately in the [kserve/community](docs/community/)
repo.

To help you get started, see the following resources:

- [KServe docs contributor's guide](docs/help/contributor/) -- Contains information about how
to contribute.

- New content templates:
- [Concept](docs/help/contributor/templates/template-concept.md)
- [Procedure](docs/help/contributor/templates/template-procedure.md)
- [Troubleshooting](docs/help/contributor/templates/template-troubleshooting.md)
- [Blog](docs/help/contributor/templates/template-blog-entry.md)

## Help and support

Your help and feedback is always welcome!

If you find an issue let us know, either by clicking the `Create Issue` on any
of the website pages, or by directly opening an
[issue](https://github.com/kserve/website/issues/new/choose) here in the repo.

If you have a question that you can't find an answer to, we would also like to
hear about that too. In addition to our docs, you can also reach out to the
community for assistance.
182 changes: 182 additions & 0 deletions docs/help/contributor/github.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,182 @@
# GitHub workflow for KServe documentation

Learn how to use GitHub and contribute to the `kserve/website` repo.


## Set up your local machine

To check out your fork of the `kserve/website` repository:

1. Create your own
[fork](https://help.github.com/articles/fork-a-repo/) of the [`kserve/website` repo](https://github.com/kserve/website).
1. Configure
[GitHub access through SSH](https://help.github.com/articles/connecting-to-github-with-ssh/).
1. Clone your fork to your machine and set the `upstream` remote to the
`kserve/website` repository:

```bash
mkdir -p ${GOPATH}/src/kserve.io
cd ${GOPATH}/src/kserve.io
git clone git@github.com:${YOUR_GITHUB_USERNAME}/website.git
cd docs
git remote add upstream https://github.com/kserve/website.git
git remote set-url --push upstream no_push
```

You are now able to open PRs, start reviews, and contribute fixes the
`kserve/website` repo. See the following sections to learn more.

**Important**: Remember to regularly
[syncing your fork](https://help.github.com/articles/syncing-a-fork/).


## Report documentation issues

<!-- This could use a pass to reduce the overhead for filing new issues,
and to consolidate items more easily during issue triage. -->

KServe uses Github issues to track documentation issues and requests. If you
see a problem with the documentation that you're not sure how to fix, submit an
issue using the following steps:

1. Check the [KServe docs issues list](https://github.com/kserve/website/issues)
before creating an issue to avoid making a duplicate.

2. Use the [correct template](https://github.com/kserve/website/issues/new) for
your new issue. There are two templates available:

- **Bug report**: If you're reporting an error in the existing
documentation, use this template. This could be anything from broken
samples to typos. When you create a bug report, include as many details as
possible and include suggested fixes to the issue.

- **Feature request**: For upcoming changes to the documentation or requests
for more information on a particular subject.

## Open PRs to fix documentation issues

The KServe documentation follows the standard
[GitHub collaboration flow](https://guides.github.com/introduction/flow/)
for Pull Requests (PRs).


<!-- This could use a pass to be more focused on what a PR submitter should do at the start of the process. -->

1. [Ensure that your fork is up-to-date](https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/syncing-a-fork).

1. [Create a branch in your fork](https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/creating-and-deleting-branches-within-your-repository).

1. Locate or create the file that you want to fix:

- If you are updating an existing page, locate that file and begin making
changes.

For example, from any page on `kserve.io`, you can click the
pencil icon in the upper right corner to open that page in GitHub.

- If you are adding new content, you must follow the
"new docs" instructions.

1. To edit a file, use the new branch that you created in your fork.

- Navigate to that same file within your fork using the GitHub UI.

- Open that file from in your local clone.

1. Create the Pull Request in the
[`kserve/website` repo](https://github.com/kserve/website/pulls).

1. [Assign an owner to the PR](#assigning-owners-and-reviewers)
to request a review.

Here's what generally happens after you send the PR for review:

1. One of the assigned repo maintainers will triage the PR by assigning
relative priority, adding appropriate labels, and performing an initial
documentation review.

2. If the PR involves significant technical changes, for example new features,
or new and changed sample code, the PR is assigned to a Subject Matter
Expert (SME), typically an engineer working on KServe, for technical review
and approval.

3. When both the technical writers and SMEs are satisfied with the quality of
the writing and the technical accuracy of the content, the PR can be merged.
A PR requires two labels before it can merge: `lgtm` and `approved`.

- The SME is responsible for reviewing the technical accuracy and adding the
`lgtm` label.

- The
[KServe technical writers](https://github.com/kserve/website/blob/main/OWNERS_ALIASES)
are who provide the `approved` label when the content meets quality,
clarity, and organization standards (see [Style Guide](#style-guide)).

We appreciate contributions to the docs, so if you open a PR we will help you
get it merged.


## Assigning owners and reviewers

All PRs should be assigned to a single owner ("_Assignee_"). It's best to set
the "Assignee" and include other stakeholders as "Reviewers" rather than leaving
it unassigned or allowing [Prow](https://prow.k8s.io/command-help) to auto
assign reviewers.

Use the `/assign` command to set the owner. For example: `/assign @owner_id`

**For code related changes**, initially set the owner of your PR to the SME who
should review for technical accuracy. If you don't know who the appropriate
owner is, nor who your reviewers should be for your PR, you can assign the
[current working group lead](https://github.com/kserve/community/tree/main/WORKING-GROUPS.md) of the related component.

If you want to notify and include other stakeholders in your PR review, use the
`/cc` command. For example: `/cc @stakeholder_id1 @stakeholder_id2`


## Reviewing PRs

[See the KServe community guidelines about reviewing PRs](https://github.com/kserve/community/blob/main/reviewing.md)


## Using Prow to manage PRs and Issues

KServe uses several sets of tools to manage pull requests (PR)s and issues in a
more fine-grained way than GitHub permissions allow. In particular, you'll
regularly interact with
[Prow](https://github.com/kubernetes/test-infra/tree/master/prow) to categorize
and manage issues and PRs. Prow allows control of specific GitHub functionality
without granting full "write" access to the repo (which would allow rewriting
history and other dangerous operations). You'll most often use the following
commands, but Prow will also chime in on most bugs and PRs with a link to all
the known commands:

- `/assign @user1 @user2` to assign an issue or PR to specific people for review
or approval.

- `/lgtm` and `/approve` to approve a PR. Note that _anyone_ may `/lgtm` a PR,
but only someone listed in an `OWNERS` file may `/approve` the PR. A PR needs
both an approval and an LGTM — the `/lgtm` review is a good opportunity for
non-approvers to practice and develop reviewing skills. `/lgtm` is removed
when a PR is updated, but `/approve` is sticky — once applied, anyone can
supply an `/lgtm`.

- Both Prow (legacy) and GitHub actions (preferred) can run tests on PRs; once
all tests are passing and a PR has the `lgtm` and `approved` labels, Prow will
submit the PR automatically.

- You can also use Prow to manage labels on PRs with `/kind ...`,
`/good-first-issue`, or `/area ...`

- See [Branches](structure.md#branches) for details about how
to use the `/cherrypick` command.

### Common GitHub PRs FAQs

* One or more tests are failing. If you do not see a specific error related to a change you made,
and instead the errors are related to timeouts, try re-running the test at a later time.
There are running tasks that could result in timeouts or rate limiting if your test runs at the same
time.

* Other Issues/Unsure -- reach out in the Slack channel and someone will be happy to help out.

Loading

0 comments on commit fe72a21

Please sign in to comment.