Allow duplicate localized entries

- Fixes #1214

Sustainsys.Saml2/Metadata/LocalizedEntryCollection.cs

@@ -1,13 +1,23 @@
-using System.Collections.ObjectModel;
+using System.Collections;
+using System.Collections.Generic;
+using System.Collections.ObjectModel;
 using System.Globalization;
 
 namespace Sustainsys.Saml2.Metadata
 {
-    public class LocalizedEntryCollection<T> : KeyedCollection<string, T> where T : LocalizedEntry
+    public class LocalizedEntryCollection<T>  : IEnumerable<T>
+        where T : LocalizedEntry
     {
-		protected override string GetKeyForItem(T item)
-		{
-			return item.Language;
-		}
+        private List<T> items = new List<T>();
+
+        public void Add(T item) => items.Add(item);
+
+        public void Clear() => items.Clear();
+
+        public int Count => items.Count;
+
+        public IEnumerator<T> GetEnumerator() => items.GetEnumerator();
+
+        IEnumerator IEnumerable.GetEnumerator() => items.GetEnumerator();
 	}
 }

Tests/Tests.Shared/Metadata/MetadataSerializerTests.cs

@@ -5650,6 +5650,23 @@ public static void AddOrganizationTestData()
 			};
 
 			AddTestData("Organization1", xml, obj);
+
+			xml = @"<?xml version='1.0' encoding='UTF-8'?>
+				<Organization xmlns='urn:oasis:names:tc:SAML:2.0:metadata'>
+					<OrganizationName xml:lang='en'>Acme Ltd</OrganizationName>
+					<OrganizationName xml:lang='en'>Ooops, duplicate entry</OrganizationName>
+				</Organization>";
+
+			obj = new Organization
+			{
+				Names = {
+					new LocalizedName("Acme Ltd", "en"),
+					new LocalizedName("Ooops, duplicate entry", "en")
+				},
+			};
+
+			AddTestData("OrganizationDuplicateNameEntries", xml, obj);
+
 		}
 
 		[TestMethod]
@@ -5659,6 +5676,13 @@ public void MetadataSerializerTests_ReadOrganization()
 				serializer.TestReadOrganization(reader));
 		}
 
+		[TestMethod]
+		public void MetadataSerializerTests_ReadOrganizationWithDuplicateNameEntries()
+		{
+			ReadTest("OrganizationDuplicateNameEntries", (serializer, reader) =>
+				serializer.TestReadOrganization(reader));
+		}
+
 		[TestMethod]
 		public void MetadataSerializerTests_WriteOrganization()
 		{