Fix all build warnings

Sustainsys · Mar 22, 2020 · c8c740c · c8c740c
1 parent 810c721
commit c8c740c
Show file tree

Hide file tree

Showing 13 changed files with 37 additions and 624 deletions.
diff --git a/Samples/SampleIdentityServer4/Views/Account/Login.cshtml b/Samples/SampleIdentityServer4/Views/Account/Login.cshtml
@@ -5,7 +5,7 @@
         <h1>Login</h1>
     </div>
 
-    @Html.Partial("_ValidationSummary")
+    <partial name="_ValidationSummary" />
 
     <div class="row">
 

diff --git a/Samples/SampleIdentityServer4/Views/Consent/Index.cshtml b/Samples/SampleIdentityServer4/Views/Consent/Index.cshtml
@@ -16,7 +16,7 @@
 
     <div class="row">
         <div class="col-sm-8">
-            @Html.Partial("_ValidationSummary")
+            <partial name="_ValidationSummary" />
 
             <form asp-action="Index" class="consent-form">
                 <input type="hidden" asp-for="ReturnUrl" />
@@ -33,7 +33,7 @@
                         <ul class="list-group">
                             @foreach (var scope in Model.IdentityScopes)
                             {
-                                @Html.Partial("_ScopeListItem", scope)
+                                <partial name="_ScopeListItem", model="@scope" />
                             }
                         </ul>
                     </div>
@@ -49,7 +49,7 @@
                         <ul class="list-group">
                             @foreach (var scope in Model.ResourceScopes)
                             {
-                                @Html.Partial("_ScopeListItem", scope)
+                                <partial name="_ScopeListItem" model="@scope" />
                             }
                         </ul>
                     </div>

diff --git a/Samples/SampleIdentityServer4AspNetIdentity/Views/Consent/Index.cshtml b/Samples/SampleIdentityServer4AspNetIdentity/Views/Consent/Index.cshtml
@@ -16,7 +16,7 @@
 
     <div class="row">
         <div class="col-sm-8">
-            @Html.Partial("_ValidationSummary")
+            <partial name="_ValidationSummary" />
 
             <form asp-action="Index" class="consent-form">
                 <input type="hidden" asp-for="ReturnUrl" />
@@ -33,7 +33,7 @@
                         <ul class="list-group">
                             @foreach (var scope in Model.IdentityScopes)
                             {
-                                @Html.Partial("_ScopeListItem", scope)
+                                <partial name="_ScopeListItem" model="@scope" />
                             }
                         </ul>
                     </div>
@@ -49,7 +49,7 @@
                         <ul class="list-group">
                             @foreach (var scope in Model.ResourceScopes)
                             {
-                                @Html.Partial("_ScopeListItem", scope)
+                                <partial name="_ScopeListItem" model="@scope" />
                             }
                         </ul>
                     </div>

diff --git a/Samples/SampleIdentityServer4AspNetIdentity/Views/Manage/ChangePassword.cshtml b/Samples/SampleIdentityServer4AspNetIdentity/Views/Manage/ChangePassword.cshtml
@@ -5,7 +5,7 @@
 }
 
 <h4>@ViewData["Title"]</h4>
-@Html.Partial("_StatusMessage", Model.StatusMessage)
+<partial name="_StatusMessage" model="@Model.StatusMessage" />
 <div class="row">
     <div class="col-md-6">
         <form method="post">
@@ -31,5 +31,5 @@
 </div>
 
 @section Scripts {
-    @await Html.PartialAsync("_ValidationScriptsPartial")
+    <partial name="_ValidationScriptsPartial" />
 }
diff --git a/Samples/SampleIdentityServer4AspNetIdentity/Views/Manage/ExternalLogins.cshtml b/Samples/SampleIdentityServer4AspNetIdentity/Views/Manage/ExternalLogins.cshtml
@@ -4,7 +4,7 @@
     ViewData.AddActivePage(ManageNavPages.ExternalLogins);
 }
 
-@Html.Partial("_StatusMessage", Model.StatusMessage)
+<partial name="_StatusMessage" model="@Model.StatusMessage" />
 @if (Model.CurrentLogins?.Count > 0)
 {
     <h4>Registered Logins</h4>

diff --git a/Samples/SampleIdentityServer4AspNetIdentity/Views/Manage/Index.cshtml b/Samples/SampleIdentityServer4AspNetIdentity/Views/Manage/Index.cshtml
@@ -5,7 +5,7 @@
 }
 
 <h4>@ViewData["Title"]</h4>
-@Html.Partial("_StatusMessage", Model.StatusMessage)
+<partial name="_StatusMessage" model="@Model.StatusMessage" />
 <div class="row">
     <div class="col-md-6">
         <form method="post">

diff --git a/Samples/SampleIdentityServer4AspNetIdentity/Views/Manage/SetPassword.cshtml b/Samples/SampleIdentityServer4AspNetIdentity/Views/Manage/SetPassword.cshtml
@@ -5,7 +5,7 @@
 }
 
 <h4>Set your password</h4>
-@Html.Partial("_StatusMessage", Model.StatusMessage)
+<partial name="_StatusMessage" model="@Model.StatusMessage" />
 <p class="text-info">
     You do not have a local username/password for this site. Add a local
     account so you can log in without an external login.
@@ -30,5 +30,5 @@
 </div>
 
 @section Scripts {
-    @await Html.PartialAsync("_ValidationScriptsPartial")
+    <partial name="_ValidationScriptsPartial" />
 }
diff --git a/Sustainsys.Saml2.HttpModule/Sustainsys.Saml2.HttpModule.csproj b/Sustainsys.Saml2.HttpModule/Sustainsys.Saml2.HttpModule.csproj
@@ -21,9 +21,9 @@
     <DefineConstants>DEBUG;TRACE</DefineConstants>
     <ErrorReport>prompt</ErrorReport>
     <WarningLevel>4</WarningLevel>
-    <RunCodeAnalysis>true</RunCodeAnalysis>
-    <CodeAnalysisRuleSet>..\Sustainsys.Saml2.ruleset</CodeAnalysisRuleSet>
+    <RunCodeAnalysis>false</RunCodeAnalysis>
     <DocumentationFile>bin\Debug\Sustainsys.Saml2.HttpModule.XML</DocumentationFile>
+    <CodeAnalysisIgnoreGeneratedCode>false</CodeAnalysisIgnoreGeneratedCode>
   </PropertyGroup>
   <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' ">
     <DebugType>pdbonly</DebugType>

diff --git a/Sustainsys.Saml2.Mvc/Sustainsys.Saml2.Mvc.csproj b/Sustainsys.Saml2.Mvc/Sustainsys.Saml2.Mvc.csproj
@@ -21,9 +21,9 @@
     <DefineConstants>DEBUG;TRACE</DefineConstants>
     <ErrorReport>prompt</ErrorReport>
     <WarningLevel>4</WarningLevel>
-    <CodeAnalysisRuleSet>..\Sustainsys.Saml2.ruleset</CodeAnalysisRuleSet>
-    <RunCodeAnalysis>true</RunCodeAnalysis>
+    <RunCodeAnalysis>false</RunCodeAnalysis>
     <DocumentationFile>bin\Debug\Sustainsys.Saml2.Mvc.XML</DocumentationFile>
+    <CodeAnalysisIgnoreGeneratedCode>false</CodeAnalysisIgnoreGeneratedCode>
   </PropertyGroup>
   <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' ">
     <DebugType>full</DebugType>

diff --git a/Sustainsys.Saml2.Owin/Sustainsys.Saml2.Owin.csproj b/Sustainsys.Saml2.Owin/Sustainsys.Saml2.Owin.csproj
@@ -22,8 +22,8 @@
     <ErrorReport>prompt</ErrorReport>
     <WarningLevel>4</WarningLevel>
     <DocumentationFile>bin\Debug\Sustainsys.Saml2.Owin.XML</DocumentationFile>
-    <RunCodeAnalysis>true</RunCodeAnalysis>
-    <CodeAnalysisRuleSet>..\Sustainsys.Saml2.ruleset</CodeAnalysisRuleSet>
+    <RunCodeAnalysis>false</RunCodeAnalysis>
+    <CodeAnalysisIgnoreGeneratedCode>false</CodeAnalysisIgnoreGeneratedCode>
   </PropertyGroup>
   <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' ">
     <DebugType>full</DebugType>