Handle overwriting config setting with unescaped falresolverr url in env var #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schroda
force-pushed
the
fix/failure_overwriting_config_setting_when_passing_unescaped_flaresolverr_url_as_env_var
branch
2 times, most recently
from
c9c613b
to
764e5f4
Compare
|
Can you update the docker-conpose example as well? |
schroda
force-pushed
the
fix/failure_overwriting_config_setting_when_passing_unescaped_flaresolverr_url_as_env_var
branch
from
764e5f4
to
05b6317
Compare
done |
|
Hmm, what about people who set FlareSolverrUrl with escaped urls? Would it be possible to support both at least for a while? |
|
this works with both |
schroda
deleted the
fix/failure_overwriting_config_setting_when_passing_unescaped_flaresolverr_url_as_env_var
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.