Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update flags if copy happens when converting ndarray to julia Array #69

Merged
merged 2 commits into from
Sep 22, 2022

Conversation

songjhaha
Copy link
Member

resolve #68

@codecov-commenter
Copy link

Codecov Report

Merging #69 (a5902ca) into main (c426a07) will decrease coverage by 1.65%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #69      +/-   ##
==========================================
- Coverage   60.76%   59.10%   -1.66%     
==========================================
  Files          11       11              
  Lines         915      873      -42     
==========================================
- Hits          556      516      -40     
+ Misses        359      357       -2     
Impacted Files Coverage Δ
TyPython/src/CPython.NumPy.jl 92.68% <100.00%> (+0.91%) ⬆️
TyPython/src/C.jl 50.00% <0.00%> (-7.15%) ⬇️
TyPython/src/CPython.APIs.jl 49.54% <0.00%> (-3.00%) ⬇️
TyPython/src/CPython.jl 52.94% <0.00%> (-2.33%) ⬇️
TyPython/src/CPython.Defs.jl 15.90% <0.00%> (-1.87%) ⬇️
TyPython/src/CPython.Boot.jl 70.21% <0.00%> (-0.63%) ⬇️
TyPython/src/CPython.Julia.jl 94.87% <0.00%> (-0.59%) ⬇️
TyPython/src/CPython.ORM.jl 97.79% <0.00%> (-0.14%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@songjhaha songjhaha merged commit e2a0d7f into main Sep 22, 2022
@songjhaha songjhaha deleted the songjhaha/fix-issue-68 branch September 26, 2022 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update flags when converting ndarray to julia Array if copy happens
3 participants