Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace "_float float_ int_ " with "float int" #94

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

DorotaLuna
Copy link

Why there would be a _ in the name?

@Suzie1
Copy link
Owner

Suzie1 commented Jan 5, 2024

good question, i'll test it without :)

@Suzie1
Copy link
Owner

Suzie1 commented Jan 5, 2024

hi, i did some tests and it looks like this change would be workflow breaking
this means that workflows using these nodes would need to be changed, and workflows attached to images would also not run without changes
i agree this would be a good change, but it could impact too many people
normally i make changes like this within the first two weeks of the node being released, before it becomes widely used
Suzie

@Suzie1
Copy link
Owner

Suzie1 commented Jan 18, 2024

Hi, DrLtData is planning changes to make it easier to update nodes. I'll keep this PR open and may implement it once these changes have been made. Suzie

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants