fix: randomizeArray with empty input returns copy now too

Sv443-Network · Feb 11, 2024 · 17a6ad5 · 17a6ad5
1 parent 5038967
commit 17a6ad5
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/.changeset/cuddly-geckos-battle.md b/.changeset/cuddly-geckos-battle.md
@@ -0,0 +1,5 @@
+---
+"@sv443-network/userutils": patch
+---
+
+`randomizeArray` now returns a copy if an empty array is passed as well
diff --git a/lib/array.ts b/lib/array.ts
@@ -37,7 +37,7 @@ export function randomizeArray<TItem = unknown>(array: TItem[]) {
   const retArray = [...array]; // so array and retArray don't point to the same memory address
 
   if(array.length === 0)
-    return array;
+    return retArray;
 
   // shamelessly stolen from https://javascript.info/task/shuffle
   for(let i = retArray.length - 1; i > 0; i--) {