Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Czech translation #137

Merged
merged 3 commits into from
Aug 3, 2020
Merged

Add Czech translation #137

merged 3 commits into from
Aug 3, 2020

Conversation

ThatCopy
Copy link
Contributor

@ThatCopy ThatCopy commented Aug 1, 2020 •
edited
Loading

Added a Czech translation

How Has This Been Tested?

npm i npm run all

Checklist

  • I have read the Contributing Guide
  • I read and accept the Code of Conduct (TLDR: just behave in a friendly manner)
  • My code follows the general style of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • I ensured that the automated checks that ran on this PR have completed successfully
  • I added myself to the package.json file (optional)

Sv443
Sv443 requested changes Aug 3, 2020
View reviewed changes
Copy link
Member

@Sv443 Sv443 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very very much for the translations! I did find some things you will need to change though.

data/errorMessages.js Outdated
@@ -37,6 +42,9 @@ module.exports = {
],
"ru": [
`Вы отправили слишком много запросов слишком быстро. Лимит составляет ${settings.httpServer.rateLimiting} запросов в пределах ${settings.httpServer.timeFrame} ${settings.httpServer.timeFrame == 1 ? "секунда" : "секунды"}.\nЕсли Вам нужно больше запросов в минуту, пожалуйста, свяжитесь со мной, и мы попробуем разобраться в этом: ${settings.info.author.website}`
],
"cs": [
`Příliš rychle jste odeslali příliš mnoho žádostí. Limit je ${settings.httpServer.rateLimiting} požadavků v rámci ${settings.httpServer.timeFrame} ${settings.httpServer.timeFrame == 1 ? "second" : "seconds"}.\n Pokud potřebujete více požadavků za minutu, kontaktujte mě a můžeme se domluvit: ${settings.info.author.website}`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This ternary is not translated: settings.httpServer.timeFrame == 1 ? "second" : "seconds"

data/errorMessages.js Outdated
@@ -208,6 +249,9 @@ module.exports = {
],
"ru": [
`Вы отправили слишком много запросов слишком быстро. Лимит - ${settings.jokes.submissions.rateLimiting} представления в пределах ${settings.jokes.submissions.timeFrame} ${settings.jokes.submissions.timeFrame == 1 ? "секунда" : "секунды" }.\nЕсли Вам нужно отправить больше запросов, пожалуйста, либо подождите немного, либо свяжитесь со мной, и мы попробуем разобраться в этом: ${settings.info.author.website}`
],
"cs": [
`Příliš rychle jste odeslali příliš mnoho žádostí. Limit je ${settings.jokes.submissions.rateLimiting} podání v rámci ${settings.jokes.submissions.timeFrame} ${settings.jokes.submissions.timeFrame == 1 ? "second" : "seconds"}.\nPokud potřebujete poslat více požadavků, počkejte prosím chvilku nebo kontaktujte mě a můžeme se domluvit: ${settings.info.author.website}`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

another untranslated ternary

data/translations.json Outdated
},
"rateLimitedShort": {
"en": "Blocked by rate limiting.",
"de": "Blockiert durch Ratenbegrenzung.",
"ru": "Блокировано ограничением скорости."
"ru": "Блокировано ограничением скорости.",
"cs": "Blokováno rate limiting."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there no translation for rate limiting? I found omezení propustnosti.

data/translations.json Outdated
},
"cantConvertToPlainText": {
"en": "Internal Error - could not convert data to plain text - %1",
"de": "Interner Fehler - konnte Daten nicht zu Text konvertieren - %1",
"ru": "Внутренняя ошибка - не удалось преобразовать данные в обычный текст - %1"
"ru": "Внутренняя ошибка - не удалось преобразовать данные в обычный текст - %1",
"cs": "Interní chyba - nelze převést data na prostý text -% 1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

space is at the wrong place

data/translations.json Outdated
},
"conversionInternalError": {
"en": "Internal Error %1 - %2\nThis error is caused by:\n- %3\n\nAdditional info: %4",
"de": "Interner Fehler %1 - %2\nDieser Fehler kann verursacht werden durch:\n- %3\n\nZusätzliche Informationen: %4",
"ru": "Внутренняя ошибка %1 - %2\nЭта ошибка может быть вызвана:\n- %3\n\nДополнительная информация: %4"
"ru": "Внутренняя ошибка %1 - %2\nЭта ошибка может быть вызвана:\n- %3\n\nДополнительная информация: %4",
"cs": "Interní chyba %1 -%2\nTato chyba je způsobena:\n- %3\n\nDalší informace: %4"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing space in front of %2

data/translations.json Outdated
},
"languagesEndpoint": {
"en": "Default Language: %1 [%2]\nJoke Languages (%3): %4\nSystem Languages (%5): %6\n\nPossible Language Values:\n%7",
"de": "Standardsprache: %1 [%2]\nWitz-Sprachen (%3): %4\nSystemsprachen (%5): %6\n\nMögliche Sprachwerte:\n%7",
"ru": "Язык по умолчанию: %1 [%2]\nЯзыки шуток (%3): %4\nСистемные языки (%5): %6\n\nВозможные значения языка:\n%7"
"ru": "Язык по умолчанию: %1 [%2]\nЯзыки шуток (%3): %4\nСистемные языки (%5): %6\n\nВозможные значения языка:\n%7",
"cs": "Výchozí jazyk: %1 [%2]\nJazyk pro vtipy (%3): %4\nSystémové jazyky(%5): %6\n\nMožné jazykové hodnoty:\n%7"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing space in front of (%5)

data/translations.json Outdated
},
"infoEndpoint": {
"en": "%1 v%2 - Info:\n\nJoke Count: %3\nCategories: \"%4\"\nFlags: \"%5\"\nResponse Formats: \"%6\"\nJoke Types: \"%7\"\nSubmission URL: %8\n\nID Ranges:\n%9\n\nJoke Languages (%10): %11\nSystem Languages (%12): %13\n\nMessage of the Day: %14",
"de": "%1 v%2 - Info:\n\nWitz-Anzahl: %3\nKategorien: \"%4\"\nMerkmale: \"%5\"\nAntwort-Dateiformate: \"%6\"\nWitz-Typen: \"%7\"\nEinreichungs-URL: %8\n\nID-Begrenzung:\n%9\n\nWitz-Sprachen (%10): %11\nSystemsprachen (%12): %13\n\nNachricht des Tages: %14",
"ru": "%1 v%2 - Информация:\n\nКоличество шуток: %3\nКатегории: \"%4\"\nФлаги: \"%5\"\nФорматы ответов: \"%6\"\nТипы шуток: \"%7\"\nАдрес отправки: %8\n\nID Диапазоны: \n%9\n\nЯзыки шуток (%10): %11\nСистемные языки (%12): %13\n\nПослание дня: %14"
"ru": "%1 v%2 - Информация:\n\nКоличество шуток: %3\nКатегории: \"%4\"\nФлаги: \"%5\"\nФорматы ответов: \"%6\"\nТипы шуток: \"%7\"\nАдрес отправки: %8\n\nID Диапазоны: \n%9\n\nЯзыки шуток (%10): %11\nСистемные языки (%12): %13\n\nПослание дня: %14",
"cs": "%1 v%2 - Informace:\n\nPočet vtipů: %3\nKategorie: \"%4\"\nVlajky: \"%5\"\nFormáty odpovědi: \"%6\"\nDruhy vtipů: \"%7\"\nURL pro odeslání vtipu: \"%8\"\n\nRozsahy ID: \n%9\n\nJazyky pro vtipy (%10): %11\nSystémové jazyky(%12): %13\n\nZpráva dne: %14"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing space in front of (%12)

@ThatCopy
Copy link
Contributor Author

ThatCopy commented Aug 3, 2020

All fixed now. For the rate limiting a better term is "omezením míry" so I used that.

Sv443
Sv443 approved these changes Aug 3, 2020
View reviewed changes
Copy link
Member

@Sv443 Sv443 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good now, thank you very much :)

@Sv443 Sv443 merged commit 27b0ece into Sv443-Network:master Aug 3, 2020
@Sv443 Sv443 mentioned this pull request Aug 4, 2020
Merged
@snyk-bot snyk-bot mentioned this pull request Dec 14, 2021
Open
@snyk-bot snyk-bot mentioned this pull request Dec 23, 2021
Open
@usernamerandom11 usernamerandom11 mentioned this pull request May 23, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sv443 Sv443 Sv443 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ThatCopy @Sv443