Rename CartRepository.deleteById() to deleteByCustomerId()

SvenWoltmann · Jun 22, 2023 · 7e59639 · 7e59639
1 parent 56b8ff7
commit 7e59639
Show file tree

Hide file tree

Showing 6 changed files with 9 additions and 9 deletions.
diff --git a/...ain/java/eu/happycoders/shop/adapter/out/persistence/inmemory/InMemoryCartRepository.java b/...ain/java/eu/happycoders/shop/adapter/out/persistence/inmemory/InMemoryCartRepository.java
@@ -27,7 +27,7 @@ public Optional<Cart> findByCustomerId(CustomerId customerId) {
   }
 
   @Override
-  public void deleteById(CustomerId customerId) {
+  public void deleteByCustomerId(CustomerId customerId) {
     carts.remove(customerId);
   }
 }
diff --git a/adapter/src/main/java/eu/happycoders/shop/adapter/out/persistence/jpa/JpaCartRepository.java b/adapter/src/main/java/eu/happycoders/shop/adapter/out/persistence/jpa/JpaCartRepository.java
@@ -41,7 +41,7 @@ public Optional<Cart> findByCustomerId(CustomerId customerId) {
   }
 
   @Override
-  public void deleteById(CustomerId customerId) {
+  public void deleteByCustomerId(CustomerId customerId) {
     try (EntityManager entityManager = entityManagerFactory.createEntityManager()) {
       entityManager.getTransaction().begin();
 

diff --git a/...src/test/java/eu/happycoders/shop/adapter/out/persistence/AbstractCartRepositoryTest.java b/...src/test/java/eu/happycoders/shop/adapter/out/persistence/AbstractCartRepositoryTest.java
@@ -113,25 +113,25 @@ void givenExistingCartWithProduct_addProductAndSaveCart_updatesTheExistingCart()
   }
 
   @Test
-  void givenExistingCart_deleteById_deletesTheCart() {
+  void givenExistingCart_deleteByCustomerId_deletesTheCart() {
     CustomerId customerId = createUniqueCustomerId();
 
     Cart existingCart = new Cart(customerId);
     cartRepository.save(existingCart);
 
     assertThat(cartRepository.findByCustomerId(customerId)).isNotEmpty();
 
-    cartRepository.deleteById(customerId);
+    cartRepository.deleteByCustomerId(customerId);
 
     assertThat(cartRepository.findByCustomerId(customerId)).isEmpty();
   }
 
   @Test
-  void givenNotExistingCart_deleteById_doesNothing() {
+  void givenNotExistingCart_deleteByCustomerId_doesNothing() {
     CustomerId customerId = createUniqueCustomerId();
     assertThat(cartRepository.findByCustomerId(customerId)).isEmpty();
 
-    cartRepository.deleteById(customerId);
+    cartRepository.deleteByCustomerId(customerId);
 
     assertThat(cartRepository.findByCustomerId(customerId)).isEmpty();
   }

diff --git a/...on/src/main/java/eu/happycoders/shop/application/port/out/persistence/CartRepository.java b/...on/src/main/java/eu/happycoders/shop/application/port/out/persistence/CartRepository.java
@@ -15,5 +15,5 @@ public interface CartRepository {
 
   Optional<Cart> findByCustomerId(CustomerId customerId);
 
-  void deleteById(CustomerId customerId);
+  void deleteByCustomerId(CustomerId customerId);
 }
diff --git a/application/src/main/java/eu/happycoders/shop/application/service/cart/EmptyCartService.java b/application/src/main/java/eu/happycoders/shop/application/service/cart/EmptyCartService.java
@@ -22,6 +22,6 @@ public EmptyCartService(CartRepository cartRepository) {
   public void emptyCart(CustomerId customerId) {
     Objects.requireNonNull(customerId, "'customerId' must not be null");
 
-    cartRepository.deleteById(customerId);
+    cartRepository.deleteByCustomerId(customerId);
   }
 }
diff --git a/...tion/src/test/java/eu/happycoders/shop/application/service/cart/EmptyCartServiceTest.java b/...tion/src/test/java/eu/happycoders/shop/application/service/cart/EmptyCartServiceTest.java
@@ -18,6 +18,6 @@ class EmptyCartServiceTest {
   void emptyCart_invokesDeleteOnThePersistencePort() {
     emptyCartService.emptyCart(TEST_CUSTOMER_ID);
 
-    verify(cartRepository).deleteById(TEST_CUSTOMER_ID);
+    verify(cartRepository).deleteByCustomerId(TEST_CUSTOMER_ID);
   }
 }