Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make is_title_mismatched more pythonic #30

Merged
merged 2 commits into from Jun 23, 2020
Merged

Make is_title_mismatched more pythonic #30

merged 2 commits into from Jun 23, 2020

Conversation

aadibajpai
Copy link
Member

the tests for this need to be better btw, to account for cases where lower upper case makes a difference.

also one problem is that we compare words in a string, so like 'yo' in 'your' will return true which we might not want.

@flabbet I was hoping you could review it once since you touched this function last 馃槂

Signed-off-by: Aadi Bajpai me@aadibajpai.me

the tests for this need to be better

Signed-off-by: Aadi Bajpai <me@aadibajpai.me>
@aadibajpai aadibajpai requested a review from flabbet June 22, 2020 03:05
@codecov
Copy link

codecov bot commented Jun 22, 2020

Codecov Report

Merging #30 into master will increase coverage by 0.98%.
The diff coverage is 86.20%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #30      +/-   ##
==========================================
+ Coverage   56.30%   57.28%   +0.98%     
==========================================
  Files           3        3              
  Lines         373      391      +18     
  Branches       49       53       +4     
==========================================
+ Hits          210      224      +14     
- Misses        152      154       +2     
- Partials       11       13       +2     
Impacted Files Coverage 螖
swaglyrics_backend/utils.py 57.30% <81.81%> (+8.04%) 猬嗭笍
swaglyrics_backend/issue_maker.py 57.14% <100.00%> (-0.57%) 猬囷笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 9dce8f3...d0cc994. Read the comment docs.

Signed-off-by: Aadi Bajpai <me@aadibajpai.me>
@pep8speaks
Copy link

Hello @aadibajpai! Thanks for updating this PR.

Line 105:21: E126 continuation line over-indented for hanging indent
Line 105:84: W504 line break after binary operator

@aadibajpai
Copy link
Member Author

Hello @aadibajpai! Thanks for updating this PR.

Line 105:21: E126 continuation line over-indented for hanging indent
Line 105:84: W504 line break after binary operator

meh

@aadibajpai aadibajpai merged commit 11d3cd0 into master Jun 23, 2020
@aadibajpai aadibajpai deleted the dev branch June 26, 2020 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants