Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/group folding #390

Merged
merged 25 commits into from
Mar 8, 2024
Merged

Feat/group folding #390

merged 25 commits into from
Mar 8, 2024

Conversation

little1d
Copy link
Contributor

@little1d little1d commented Mar 5, 2024

Description

  1. Fix bug [FEATURE] 记住分组是否折叠 #381
  • memory charts' open and close states
  • add two objects to memory the states
    image
  • object has a embedding object (named as experiment's name)
    image

#381

@little1d little1d self-assigned this Mar 5, 2024
@little1d little1d added the 🐛 bug Something isn't working label Mar 5, 2024
@little1d little1d requested a review from SAKURA-CAT March 5, 2024 10:43
@little1d little1d linked an issue Mar 5, 2024 that may be closed by this pull request
[FEATURE] 记住分组是否折叠 #381
Closed
SAKURA-CAT
SAKURA-CAT requested changes Mar 5, 2024
View reviewed changes
vue/src/charts/ChartsContainer.vue Outdated Show resolved Hide resolved
vue/src/views/charts/components/ChartsPage.vue Outdated Show resolved Hide resolved
vue/src/views/experiment/pages/chart/ChartPage.vue Outdated Show resolved Hide resolved
vue/src/views/charts/components/ChartsPage.vue Outdated Show resolved Hide resolved
@little1d little1d changed the title Bugfix/group folding Feat/group folding Mar 5, 2024
@Zeyi-Lin Zeyi-Lin added this to the v0.2.3 milestone Mar 8, 2024
@SAKURA-CAT SAKURA-CAT marked this pull request as draft March 8, 2024 04:54
@SAKURA-CAT SAKURA-CAT marked this pull request as ready for review March 8, 2024 12:53
@SAKURA-CAT SAKURA-CAT requested a review from Zeyi-Lin March 8, 2024 12:53
@little1d little1d merged commit b5cb6ef into main Mar 8, 2024
@little1d little1d deleted the bugfix/group-folding branch March 8, 2024 13:13
@little1d little1d added 💪 enhancement New feature or request and removed 🐛 bug Something isn't working labels Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SAKURA-CAT SAKURA-CAT SAKURA-CAT approved these changes

@Zeyi-Lin Zeyi-Lin Awaiting requested review from Zeyi-Lin

Assignees

@little1d little1d

Labels
💪 enhancement New feature or request
Projects
None yet
Milestone
v0.2.3
Development

Successfully merging this pull request may close these issues.

[FEATURE] 记住分组是否折叠
3 participants
@little1d @SAKURA-CAT @Zeyi-Lin