Updated all files with JsDocs #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SwapnikKatkoori I left some comments where I'm not sure what the correct type is, or how the function works. If you could give me some guidance that'd be great! Once this is done I can make the Typescript typings |
zbot473
suggested changes
May 2, 2020
| @@ -1,2 +1,3 @@ | |||
| node_modules/ | |||
| **/.DS_Store | |||
| .idea/ | |||
There was a problem hiding this comment.
If we're ignoring IDEs, maybe add .vscode/ too
There was a problem hiding this comment.
I'll get that done. Can you look at those todos and write jsDocs for them?
There was a problem hiding this comment.
Should I create a PR on your fork, or do you just want me to suggest changes?
There was a problem hiding this comment.
You can clone my fork and make the changes on the branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #8
Still not done as of time of writing, just giving everyone a headsup that I'm working on this