Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: update CoWTrade #1280

Merged
merged 9 commits into from
Aug 8, 2022
Merged

feature: update CoWTrade #1280

merged 9 commits into from
Aug 8, 2022

Conversation

adamazad
Copy link
Contributor

Summary

Updates and CoWTrade to the newest Cow SDK. Addresses #1255 by sending back the quoteId to POST /order endpoint. This PR uses the RC v1.6.0 of the SDK.

@adamazad adamazad linked an issue Jul 27, 2022 that may be closed by this pull request
@netlify
Copy link

netlify bot commented Jul 27, 2022

Deploy Preview for swapr ready!

Name Link
🔨 Latest commit 8e58f42
🔍 Latest deploy log https://app.netlify.com/sites/swapr/deploys/62f0fadf8250b0000806964a
😎 Deploy Preview https://deploy-preview-1280--swapr.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot temporarily deployed to feature-1276-update-cowtrade July 27, 2022 14:02 Destroyed
Copy link
Contributor

@jorgedclopes jorgedclopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MilanVojnovic95
Copy link
Collaborator

If I try to swap from XDAI to USDC or USDT I don't get COW swap as an option in the exchange list
and when I try from USDC to 1INCH I get this error message.

Swapr.28.07_01.mp4

feat(#1276): update SDK to v1.6.0-rc.0
@adamazad adamazad force-pushed the feature/1276-update-cowtrade branch from 72159a5 to 4cc22fd Compare July 28, 2022 09:42
@github-actions github-actions bot temporarily deployed to feature-1276-update-cowtrade July 28, 2022 09:52 Destroyed
@adamazad
Copy link
Contributor Author

@MilanVojnovic95 can you give it another test? Thanks

@niemam29
Copy link
Contributor

niemam29 commented Jul 28, 2022

After i've approved some token and tried to swap the error message says that i've got insufficient funds (i used the max button soo it shouldnt happen), also after changing some tokens swapr crashed. This may be hard do recreate, soo if you face any problems please let me know.

screen-capture.webm

Browser logs:
logs.txt

@github-actions github-actions bot temporarily deployed to feature-1276-update-cowtrade July 28, 2022 17:04 Destroyed
@github-actions github-actions bot temporarily deployed to feature-1276-update-cowtrade August 2, 2022 17:38 Destroyed
@Mi-Lan
Copy link
Collaborator

Mi-Lan commented Aug 2, 2022

Screenshot 2022-08-02 at 20 27 02
Screenshot 2022-08-02 at 20 27 37
Seems that there is some issue when trying to swap cow...
This is all after I sign the transaction here is one more saying I have innsuficient balance
Screenshot 2022-08-02 at 20 31 56

@Mi-Lan
Copy link
Collaborator

Mi-Lan commented Aug 2, 2022

Seems that its for every pair. And it scrolled by itself for some reason...

Screen.Recording.2022-08-02.at.20.34.14.mov

.

Copy link
Contributor

@mix1o mix1o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice!

src/state/transactions/updater.tsx Show resolved Hide resolved
src/state/transactions/updater.tsx Outdated Show resolved Hide resolved
src/state/transactions/updater.tsx Outdated Show resolved Hide resolved
src/state/transactions/updater.tsx Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to feature-1276-update-cowtrade August 3, 2022 10:07 Destroyed
@Diogomartf
Copy link
Collaborator

Tested swaping xDai to aave and worked great. ✔

@adamazad adamazad self-assigned this Aug 3, 2022
@adamazad
Copy link
Contributor Author

adamazad commented Aug 3, 2022

Great catch @Mi-Lan. The issue was fixed in SwaprHQ/swapr-sdk#180.

I'm waiting for #1287 to be merged to avoid confusion about the scope. Then, release the next version of the SDK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update CoWTrade
7 participants