-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: update CoWTrade #1280
feature: update CoWTrade #1280
Conversation
✅ Deploy Preview for swapr ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
If I try to swap from XDAI to USDC or USDT I don't get COW swap as an option in the exchange list Swapr.28.07_01.mp4 |
feat(#1276): update SDK to v1.6.0-rc.0
72159a5
to
4cc22fd
Compare
@MilanVojnovic95 can you give it another test? Thanks |
After i've approved some token and tried to swap the error message says that i've got insufficient funds (i used the max button soo it shouldnt happen), also after changing some tokens swapr crashed. This may be hard do recreate, soo if you face any problems please let me know. screen-capture.webmBrowser logs: |
Seems that its for every pair. And it scrolled by itself for some reason... Screen.Recording.2022-08-02.at.20.34.14.mov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice!
Tested swaping xDai to aave and worked great. ✔ |
Great catch @Mi-Lan. The issue was fixed in SwaprHQ/swapr-sdk#180. I'm waiting for #1287 to be merged to avoid confusion about the scope. Then, release the next version of the SDK |
Summary
Updates and
CoWTrade
to the newest Cow SDK. Addresses #1255 by sending back thequoteId
toPOST /order
endpoint. This PR uses the RC v1.6.0 of the SDK.