Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI header and navigation for DXswap #56

Merged
merged 12 commits into from
Oct 29, 2020
Merged

UI header and navigation for DXswap #56

merged 12 commits into from
Oct 29, 2020

Conversation

AugustoL
Copy link

  • Removed the identicons and logos for wallets, just displaying the address.
  • Merged Menu component into Settings, now showing everything in one dropdown.
  • Added Governance "coming soon" tab in header.
  • Remove bottom border from header.
  • Minor adjustments into header to get as close as figma design as I could.

@AugustoL
Copy link
Author

Screenshot from 2020-10-28 16-39-24

@AugustoL AugustoL requested a review from zamli October 28, 2020 19:40
zamli
zamli requested changes Oct 28, 2020
View reviewed changes
Copy link
Collaborator

@zamli zamli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
settings not popping up on mobile

@zamli
Copy link
Collaborator

zamli commented Oct 28, 2020

image
navigation items out of view on mobile

@zamli
Copy link
Collaborator

zamli commented Oct 28, 2020

image
make governance a non clickable item. me and @luzzif could maybe do this together with theming

@zamli
Copy link
Collaborator

zamli commented Oct 28, 2020

the rest of the issues are theme issues that I and @luzzif will solve.
This includes, change logo to new svg provided in figma, changing the colors items, fonts, spacing between navigation

@zamli zamli mentioned this pull request Oct 29, 2020
Closed
@AugustoL
Copy link
Author

@zamli @luzzif mobile bugs should be fixed and TODO for the badge added.

@AugustoL AugustoL self-assigned this Oct 29, 2020
@AugustoL AugustoL merged commit 386cd3b into develop Oct 29, 2020
@adamazad adamazad deleted the refactor/40 branch February 9, 2022 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luzzif luzzif luzzif approved these changes

@zamli zamli zamli approved these changes

Assignees

@AugustoL AugustoL

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AugustoL @zamli @luzzif