Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/906 add dfyn dex #912

Merged
merged 3 commits into from Apr 25, 2022
Merged

Feature/906 add dfyn dex #912

merged 3 commits into from Apr 25, 2022

Conversation

jorgedclopes
Copy link
Contributor

Summary

Fixes #906
Adds DFYN to the routing options when swapping.

image
Image - On localhost

Background

In order to add more options/value to our platform, we want to add more relevant dexes to the list of swap options.

To Test/Replicate

  1. Follow the procedure to link the SDK locally (see below)
  2. yarn build
  3. Change network to Polygon
  4. Select compatible token pair.

IMPORTANT

This PR uses unreleased SDK.

TL;DR
To make it work you need to build & link this SDK branch locally.

How to do that: (from relevant PR)

Clone SDK repo locally
Checkout to feature/add-polygon-config on the SDK repo
run yarn prepublishOnly
run yarn link
cd to swapr-dApp and run yarn link @swapr/sdk
All types/missing imports should work fine now.

After you're done playing with linked repo you need to unlink local build. To do this, in your swapr-dApp run yarn unlink @swapr/sdk && yarn install --force

Copy link
Contributor

@denciu denciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@denciu denciu merged commit b66bd0d into SwaprHQ:feature/add-polygon-support Apr 25, 2022
@jorgedclopes jorgedclopes deleted the feature/906-add-dfyn-dex branch April 25, 2022 13:22
adamazad pushed a commit that referenced this pull request May 9, 2022
adamazad added a commit that referenced this pull request May 9, 2022
@denciu denciu mentioned this pull request May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants